feat(executor): Support K8S JSON patch with resource template. Closes #4883

[book987]

#4883

Checklist:

• My organization is added to USERS.md.

[alexec]

Failing test

   --- FAIL: TestFunctionalSuite/TestK8SJSONPatch (4.45s)
        functional_test.go:1028: 
            	Error Trace:	functional_test.go:1028
            	            				then.go:57
            	            				then.go:32
            	            				functional_test.go:1025
            	Error:      	Not equal: 
            	            	expected: ""
            	            	actual  : "Error from server (Forbidden): error when retrieving current configuration of:\nResource: \"/v1, Resource=serviceaccounts\", GroupVersionKind: \"/v1, Kind=ServiceAccount\"\nName: \"test-sa\", Namespace: \"argo\"\nfrom server for: \"/tmp/manifest.yaml\": serviceaccounts \"test-sa\" is forbidden: User \"system:serviceaccount:argo:default\" cannot get resource \"serviceaccounts\" in API group \"\" in the namespace \"argo\"\nError from server (Forbidden): error when retrieving current configuration of:\nResource: \"rbac.authorization.k8s.io/v1, Resource=roles\", GroupVersionKind: \"rbac.authorization.k8s.io/v1, Kind=Role\"\nName: \"test-role\", Namespace: \"argo\"\nfrom server for: \"/tmp/manifest.yaml\": roles.rbac.authorization.k8s.io \"test-role\" is forbidden: User \"system:serviceaccount:argo:default\" cannot get resource \"roles\" in API group \"rbac.authorization.k8s.io\" in the namespace \"argo\"\nError from server (Forbidden): error when retrieving current configuration of:\nResource: \"rbac.authorization.k8s.io/v1, Resource=rolebindings\", GroupVersionKind: \"rbac.authorization.k8s.io/v1, Kind=RoleBinding\"\nName: \"test-role-binding\", Namespace: \"argo\"\nfrom server for: \"/tmp/manifest.yaml\": rolebindings.rbac.authorization.k8s.io \"test-role-binding\" is forbidden: User \"system:serviceaccount:argo:default\" cannot get resource \"rolebindings\" in API group \"rbac.authorization.k8s.io\" in the namespace \"argo\""

I think you need to look at workflow-role.yaml to see what permissions you have. I suggest that you have pod patch so maybe change the resource to a pod.

[book987]

I suggest that you have pod patch so maybe change the resource to a pod.

It works! Thanks!

[alexec]

LGTM!

[wreed4]

🎉 yay merged!

@alexec Out of curiosity, just trying to understand the release Argo Workflows release process, when should I expect to see this make it's way into a released tag? We're waiting on it to adopt v3.x, but the main reason I'm asking isn't to rush, just to understand. it's a huge project with so many branches and commits coming in it's mind boggling!

Maybe a second question would be how would I know which tag it's in when it does get released? will it show up on this PR? or should I just keep an eye on the changelogs?

[terrytangyuan]

You can see a list of tags in this commit 6e961ec

[wreed4]

perfect thanks @terrytangyuan

[wreed4]

ope, I meant to comment on #5951 I'm blind. But answer applies anyways! Thanks! :)