fix(executor): Fix resource patch when not providing flags. Fixes #5310

[terrytangyuan]

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

• My organization is added to USERS.md.

[terrytangyuan]

Seems like a bug introduced in #4908 and a regression since v3.0.0-rc1.

[alexec]

@book987 can you please take a look?

[terrytangyuan]

Rebased and finally passed the CI. @alexec Thanks for making the CI more robust! I think this is ready to go unless I missed anything else.

[wreed4]

@alexec it seems like this fix is still not available in 3.0.1, 3.0.2, or 3.0.3. I can see the cherry-picks above, but I can't see it in the changelogs, and most importantly, we have verified the bug still exists in all three of those versions. believe we tested 3.0.4 as well but not positive. Can you give any insight into when this will be available?

[wreed4]

upon further looking actually.... looks like this particular code is there, but the syntax for patch must have changed from 2.X?? Are there docs on that I can't seem to find them. I'm now getting this error: Error (exit code 1): error: You must provide one or more resources by argument or filename. with this patch

  - name: patch
    resource:
      action: patch
      manifest: |
        apiVersion: v1
        kind: ConfigMap
        metadata:
          name: patch-test-{{workflow.name}}
          annotations:
            patched: "true"

the same code works in 2.x

[wreed4]

It's this line here https://github.com/argoproj/argo-workflows/blob/master/workflow/executor/resource.go#L107
It prevents passing the file so kubectl doesn't know which object to pass. I'd definitely consider this a regression. Docs seems like they are not updated either to reflect an intentional change. https://github.com/argoproj/argo-workflows/tree/v3.0.4/examples#kubernetes-resources