chore: Support substitute global variable in Spec level elements #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
sarabala1979
commented
Apr 5, 2021
| wftmplGetter := templateresolution.WrapWorkflowTemplateInterface(woc.controller.wfclientset.ArgoprojV1alpha1().WorkflowTemplates(woc.wf.Namespace)) | ||
| cwftmplGetter := templateresolution.WrapClusterWorkflowTemplateInterface(woc.controller.wfclientset.ArgoprojV1alpha1().ClusterWorkflowTemplates()) | ||
|
|
||
| // Validate the execution wfSpec |
There was a problem hiding this comment.
Moving to SetWorkflowSpec
simster7
reviewed
Apr 6, 2021
simster7
approved these changes
Apr 6, 2021
alexec
reviewed
Apr 7, 2021
alexec
reviewed
Apr 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #5565 +/- ##
==========================================
- Coverage 47.07% 47.03% -0.04%
==========================================
Files 240 240
Lines 15034 15050 +16
==========================================
+ Hits 7077 7079 +2
- Misses 7057 7069 +12
- Partials 900 902 +2
Continue to review full report at Codecov.
|
tobisinghania
pushed a commit
to tobisinghania/argo-workflows
that referenced
this pull request
Apr 12, 2021
…oproj#5565) Signed-off-by: tobi <mail@singhania.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
Checklist:
closes
workflow.parameterscannot be referenced insynchronizationfield #4894