Introduce communication channel from workflow-controller to executor through pod annotations #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The contents of the new file steps.go is code which moved from operation.go but with tweaked killDeamonedChildren to use the new method updateExecutionControl(). |
jessesuen
force-pushed
the
execution-control
branch
2 times, most recently
from
63c3753
to
f431bfe
Compare
Merged
shrinandj
reviewed
Jan 15, 2018
examples/hello-world.yaml
Outdated
| command: [cowsay] | ||
| args: ["hello world"] | ||
| command: [sh, -c] | ||
| args: ["sleep 30"] |
There was a problem hiding this comment.
This is a mistake. Thanks for catching this.
jessesuen
force-pushed
the
execution-control
branch
from
f431bfe
to
a2ce879
Compare
…through pod annotations This change creates a downward communication channel from the controller to executor through the use of pod annotations. Its initial use will be to terminate daemoned containers by updating 'ExecutionControl' parameters to the executor. In this case, it updates the deadline value to be a zero-value timestamp. The executor now monitors updates to the annotations and will use the updated deadline, allowing deadlines to be set/updated/unset after initial start. In the future, ExecutionControl can be extended to support things like workflow, step, dag level timeouts, as well as the ability to to cancel a workflow without deleting pods.
jessesuen
force-pushed
the
execution-control
branch
from
a2ce879
to
7e6897e
Compare
shrinandj
approved these changes
Jan 16, 2018
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
* feat: Add afterStart filter to resource type eventsource * examples * fix testcase * refac * test case * added log * new line * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a downward communication channel from the controller to executor through
the use of pod annotations. Its initial use will be to terminate daemoned containers by
updating 'ExecutionControl' parameters to the executor. In this case, it updates the deadline
value to be a zero-value timestamp. The executor has been modified to now monitor updates to the annotations and will obey the updated deadline, allowing deadlines to be set/updated/unset after initial start.
In the future, ExecutionControl can be extended to support things like workflow, step, dag
level timeouts, as well as the ability to to cancel a workflow without deleting pods.
Resolves issue #499.
Partially implements support for #527.