Enable more semantic tests for Ewasm #11305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Apr 23, 2021
| // getChoiceFromMax() -> FAILURE, hex"4e487b71", 33 | ||
| // getChoiceExp(uint256): 3 -> FAILURE, hex"4e487b71", 0x21 # These should throw # | ||
| // getChoiceFromSigned(int256): -1 -> FAILURE, hex"4e487b71", 0x21 | ||
| // getChoiceFromMax() -> FAILURE, hex"4e487b71", 0x21 |
Contributor
Author
There was a problem hiding this comment.
@cameel you asked about this change in another PR, and since this is a panic code IIRC, the hex version makes more sense
cameel
approved these changes
Apr 23, 2021
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
Haven't reviewed it too thoroughly but it only enables the compileToEwasm flag so it can't hurt as long as CI is green. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #10356