Refactor CLI output selection flags #12070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
refactor-cli-output-flags
branch
from
22881a3 to
bdfbbeb
Compare
Base automatically changed from
remove-combined-json-compact-format-leftovers
to
develop
October 1, 2021 12:40
cameel
force-pushed
the
refactor-cli-output-flags
branch
from
bdfbbeb to
8a76957
Compare
Collaborator
Author
|
#12069 has been merged so this is now reviewable. |
leonardoalt
approved these changes
Oct 4, 2021
leonardoalt
left a comment
leonardoalt
left a comment
There was a problem hiding this comment.
I haven't tried the binary myself, but I'm assuming you did?
Collaborator
Author
|
Yeah, I did some manual testing in #12074, which is on top of it. I did not test every single flag but we do have test coverage for some of these flags (in command-line tests and some in the new tests for solc) and if they're not broken, I doubt the others are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12069. In draft mode until that PR is merged.Merged.A small refactor to bring the structs that represent sets of boolean flags for selecting compiler outputs more in line with what I did with
DebugInfoSelectionin #11944. Now they use maps of pointer-to-members to avoid enumerating fields by hand - this gets really repetitive and error prone with structs that have 15+ fields.This is needed for the next PR which actually changes the validation logic.