Validate selected compiler outputs on the CLI #12071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
cli-validate-output-selection
branch
from
71b3b0e to
12f1312
Compare
cameel
force-pushed
the
refactor-cli-output-flags
branch
from
22881a3 to
bdfbbeb
Compare
cameel
force-pushed
the
cli-validate-output-selection
branch
2 times, most recently
from
813ea59 to
e7fc139
Compare
Collaborator
Author
|
#12070 merged so this is now reviewable. |
Collaborator
Author
|
This change is technically breaking, but it could be argued that it's a bugfix (see #11730 (comment)) if we consider missing CLI validations bugs rather than missing features. |
cameel
force-pushed
the
cli-validate-output-selection
branch
from
e7fc139 to
a3fa5d7
Compare
cameel
force-pushed
the
cli-validate-output-selection
branch
from
a3fa5d7 to
b9b2c69
Compare
Marenz
approved these changes
Oct 11, 2021
|
|
||
| switch (_mode) | ||
| { | ||
| case InputMode::Compiler: |
Contributor
There was a problem hiding this comment.
Ah, I thought we need explicit [[fallthrough]]; but if this works, great!
Collaborator
Author
There was a problem hiding this comment.
We only need that if there's anything between the labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #11629.
Depends on #12070. In draft mode until that PR is merged.Merged.This makes the compiler report errors when outputs that are unavailable in the current input mode are selected via CLI flags.
This was originally a part of a bigger PR that enables output selection in assembly mode but it actually also makes sense on its own and can be considered a separate feature/fix.