[CI] Reusable command for gitter notifications #12182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
circleci-gitter-notification-command
branch
from
c8ada5e to
044f418
Compare
cameel
force-pushed
the
circleci-gitter-notification-command
branch
from
db5d6e5 to
a4fce30
Compare
Contributor
|
@cameel Was this tested by any chance? Looks good. Can approve if this was tested. We can also test in prod :) |
Contributor
|
Yeah, I think the easiest is to test it in production, as it explicitly excludes PRs. Though of course you could add a test-commit that removes that exception so it runs on PRs as well. |
Marenz
approved these changes
Oct 25, 2021
Contributor
Marenz
left a comment
Marenz
left a comment
There was a problem hiding this comment.
LGTM. I am okay with production testing, but a simple commit that removes the PR exclusion might also do the trick to test it
Collaborator
Author
|
@hrkrshnn I did test it but not very extensively (I didn't want to spam the channel and also the variables are going to be different in non-PR runs anyway so it's not foolproof). I tested it together with #12181. Take a look at #12181 (comment). |
Collaborator
Author
hrkrshnn
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactor, extracted into a separate PR because I need it in more than one other PR.
It converts the existing notification step templates into a parameterized and reusable command. This reduces duplication and makes it easier to add new notifications (which is needed in #12181).