Add missing condition to gitter_notify command
#12190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small bug introduced in #12182. I did test it but only really to check that notifications appear. Turns out I did not notice that the condition that ensures that notification only shows up on success/failure was missing from the command. This PR adds it.
Without the fix, notifications from nightly jobs are sent unconditionally. I tested the fix in 3 scenarios:
b_docsjob withon_failcondition. No notification.b_docsjob withon_successcondition. A success notification was sent.b_docsjob withon_failcondition. A failure notification was sent.