Skip to content

Numerical Yul node id handles #15215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Numerical Yul node id handles #15215

wants to merge 15 commits into from

Conversation

@clonker
Copy link
Member

@clonker clonker commented Jun 24, 2024 •
edited
Loading

ekpyron
ekpyron reviewed Jun 25, 2024
View reviewed changes
ekpyron
ekpyron reviewed Jun 25, 2024
View reviewed changes
libsolidity/ast/AST.h Outdated

private:
yul::Dialect const& m_dialect;
std::unique_ptr<yul::YulNameRepository> mutable m_yulNameRepository;
Copy link
Collaborator

@ekpyron ekpyron Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be mutable? Usually that's a good indication of some design flaw :-).

Copy link
Member Author

@clonker clonker Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, it's one place where I am not happy with the code yet :) it was already on my todo to iron out

@clonker clonker force-pushed the yul_node_handles branch from a6f45b1 to 6b1b3dc Compare July 2, 2024 09:01
@clonker clonker mentioned this pull request Jul 5, 2024
Closed
@clonker clonker force-pushed the yul_node_handles branch from 2359805 to 0d97464 Compare July 9, 2024 12:36
@clonker clonker mentioned this pull request Jul 11, 2024
Merged
@clonker clonker added the has dependencies The PR depends on other PRs that must be merged first label Jul 31, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 21, 2024
@github-actions github-actions bot closed this Aug 28, 2024
@cameel cameel reopened this Aug 29, 2024
@argotorg argotorg deleted a comment from github-actions bot Aug 29, 2024
@argotorg argotorg deleted a comment from github-actions bot Aug 29, 2024
@cameel cameel removed stale The issue/PR was marked as stale because it has been open for too long. closed-due-inactivity labels Aug 29, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 1, 2024
@cameel cameel mentioned this pull request Oct 11, 2024
Open
4 tasks
@github-actions
Copy link

github-actions bot commented Oct 15, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 15, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 15, 2024
@github-actions
Copy link

github-actions bot commented Oct 30, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 30, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 30, 2024
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 14, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 15, 2024
@ekpyron ekpyron added the 🟡 PR review label label Nov 20, 2024
@github-actions
Copy link

github-actions bot commented Dec 5, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Dec 5, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Dec 5, 2024
@github-actions
Copy link

github-actions bot commented Dec 20, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Dec 20, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Dec 21, 2024
@github-actions
Copy link

github-actions bot commented Jan 5, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jan 5, 2025
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Jan 5, 2025
@github-actions
Copy link

github-actions bot commented Jan 20, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jan 20, 2025
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Jan 20, 2025
@ekpyron ekpyron mentioned this pull request Jan 27, 2025
Open
@github-actions
Copy link

github-actions bot commented Feb 4, 2025

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Feb 4, 2025
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

This pull request was closed due to a lack of activity for 7 days after it was stale.

@github-actions github-actions bot closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekpyron ekpyron ekpyron left review comments

Assignees

No one assigned

Labels

closed-due-inactivity has dependencies The PR depends on other PRs that must be merged first stale The issue/PR was marked as stale because it has been open for too long. 🟡 PR review label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clonker @ekpyron @cameel