Skip to content

[circleci] Enable ewasm tests. #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chriseth merged 1 commit into from
Oct 1, 2020
Merged

[circleci] Enable ewasm tests. #9481

chriseth merged 1 commit into from
Oct 1, 2020
+14 −3

Conversation

@aarlt
Copy link
Contributor

@aarlt aarlt commented Jul 22, 2020 •
edited
Loading

Replaces #9212.

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from b409163 to 291c84a Compare July 23, 2020 11:52
@aarlt
Copy link
Contributor Author

aarlt commented Jul 23, 2020

For now: run soltest ewasm tests without optimization only. See https://gist.github.com/aarlt/ff0ff4d453bd0c1f708e82c0ac82cad6#file-soltest-ewasm-error

chriseth
chriseth reviewed Jul 23, 2020
View reviewed changes
leonardoalt
leonardoalt reviewed Jul 23, 2020
View reviewed changes
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 4 times, most recently from ec2e83c to 066d5bf Compare July 26, 2020 19:08
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch 3 times, most recently from d3e0a06 to 0d1a745 Compare July 27, 2020 17:38
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch from 066d5bf to 699189b Compare July 27, 2020 17:40
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch 4 times, most recently from 234af3b to edd351a Compare July 27, 2020 18:06
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 2 times, most recently from c762304 to 55baf62 Compare July 27, 2020 23:39
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from edd351a to d3eb416 Compare July 27, 2020 23:41
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 3 times, most recently from e64a5ad to 69b735c Compare July 31, 2020 14:36
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch 6 times, most recently from cdddda1 to 88af39d Compare August 3, 2020 15:41
@aarlt aarlt mentioned this pull request Aug 3, 2020
Merged
3 tasks
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from 88af39d to f66a09a Compare August 3, 2020 16:24
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch 2 times, most recently from 660d94e to cc2d4c7 Compare August 31, 2020 10:47
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 2 times, most recently from 86d22cb to e2a7a4e Compare September 2, 2020 00:05
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from cc2d4c7 to 8401947 Compare September 2, 2020 00:06
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 4 times, most recently from 880856d to 10c0105 Compare September 3, 2020 20:38
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from 8401947 to b33c148 Compare September 3, 2020 23:50
@aarlt
Copy link
Contributor Author

aarlt commented Sep 4, 2020

Can you also take a look at the other (non-circleci) scripts that execute the tests like scripts/tests.sh?

@chriseth I updated scripts/tests.sh, there seem to be no other other related scripts.

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 3 times, most recently from b83df92 to 23d9b15 Compare September 8, 2020 17:41
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from b33c148 to fed44e9 Compare September 8, 2020 17:48
Base automatically changed from evmc-vms-evm-ewasm to develop September 9, 2020 09:13
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from fed44e9 to 5b11da5 Compare September 17, 2020 02:50
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from 5b11da5 to d95c716 Compare September 29, 2020 00:35
@aarlt aarlt requested a review from chriseth September 29, 2020 00:39
chriseth
chriseth reviewed Sep 29, 2020
View reviewed changes
chriseth
chriseth reviewed Sep 29, 2020
View reviewed changes
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch 3 times, most recently from 34c768e to fbbd72a Compare September 30, 2020 22:46
chriseth
chriseth reviewed Oct 1, 2020
View reviewed changes
.circleci/soltest_all.sh Outdated
EWASM_ARGS=""
[ "${EVM}" = "byzantium" ] && [ "${OPTIMIZE}" = "0" ] && EWASM_ARGS="--ewasm"

[[ " $RUN_STEPS " =~ " $STEP " ]] && EVM="$EVM" OPTIMIZE="$OPTIMIZE" SOLTEST_FLAGS="$EWASM_ARGS" BOOST_TEST_ARGS="-t !@nooptions" "${REPODIR}/.circleci/soltest.sh"
Copy link
Contributor

@chriseth chriseth Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables any SOLTEST_FLAGS passed in from outside, right? Shouldn't we change it to SOLTEST_FLAGS="$SOLTEST_FLAGS $EWASM_ARGS"?

Copy link
Contributor Author

@aarlt aarlt Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats true

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm-ci branch from fbbd72a to d38eb75 Compare October 1, 2020 18:22
@chriseth chriseth merged commit 875dc0f into develop Oct 1, 2020
@chriseth chriseth deleted the evmc-vms-evm-ewasm-ci branch October 1, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@leonardoalt leonardoalt leonardoalt left review comments

@chriseth chriseth chriseth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aarlt @leonardoalt @chriseth