Skip to content

Conversation

@aarlt
Copy link
Contributor

@aarlt aarlt commented Jun 5, 2020

Closes #8016.

Replaces #9057.

This PR enables the possibility to run tests against ewasm evmc vms.

In contrast to #9057, where n-evmc vms could be defined, this PR is more simple. It enables the definition of up-to two different evmc libaries. To execute the tests, at least one evm1 vm must be defined (either through the --evmonepath parameter, or with --vm), where the defintion of an ewasm vm is optional. If an ewasm evmc library was defined (via --vm), tests will also run against that ewasm evmc vm.

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 2 times, most recently from a3df20e to a9deb55 Compare June 8, 2020 18:52
@axic
Copy link
Contributor

axic commented Jun 9, 2020

@aarlt we are working on landing ewasm/hera#554. It will be released as Hera 0.3.0.

@axic
Copy link
Contributor

axic commented Jun 9, 2020

@aarlt done, available here: https://github.com/ewasm/hera/releases/tag/v0.3.0

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch from a9deb55 to 6b58e19 Compare June 10, 2020 01:04
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 6 times, most recently from e060d9e to 3646847 Compare June 13, 2020 17:43
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch from da03b42 to a439bd2 Compare June 15, 2020 12:57
@aarlt
Copy link
Contributor Author

aarlt commented Jun 15, 2020

Some test-cases seem to hang inside hera (e.g. nested_for_loop_multiple_local_vars). It looks like that this is mainly related to tests using loops that generate infinity loops. Right now metering is not enabled for the ewasm tests. I think some tests hang in hera because of not enabled metering and wrongly generated code leading to infinity loops.

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch from a439bd2 to 583bbbb Compare June 16, 2020 23:55
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 7 times, most recently from 72cad18 to 93026b7 Compare September 2, 2020 14:08
@aarlt
Copy link
Contributor Author

aarlt commented Sep 2, 2020

What is the status here?

@chriseth I think it's ready. I split out the CircleCI integration #9481 and currently trying to enable as much tests as possible while fixing some polyfills in #9508. From my point of view this PR #9143 and the CircleCI #9481 could get merged. All ewasm based tests are disabled in #9481 and #9143. Related tests get enabled in #9508.

One thing: I added in a new CircleCI job t_osx_test in #9481 that will also run soltest_all.sh in osx. If #9508 is passing the tests now, it would be nice to merge #9481 and #9143. And then we can fully focus on getting #9508 ready.

I removed now the t_osx_test CircleCI job. Maybe we should think about how to extent the bytecode comparision tests with ewasm.

@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 2 times, most recently from 880856d to 10c0105 Compare September 3, 2020 20:38
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch 2 times, most recently from ff483e3 to b83df92 Compare September 7, 2020 23:00
@aarlt aarlt force-pushed the evmc-vms-evm-ewasm branch from b83df92 to 23d9b15 Compare September 8, 2020 17:41
@chriseth chriseth merged commit d089b56 into develop Sep 9, 2020
@chriseth chriseth deleted the evmc-vms-evm-ewasm branch September 9, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Hera (next to evmone) in tests for Ewasm

4 participants