Skip to content

Conversation

@chfast
Copy link
Collaborator

@chfast chfast commented Nov 10, 2019

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2019

This pull request introduces 1 alert and fixes 1 when merging b2093e9 into cebfb99 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

fixed alerts:

  • 1 for FIXME comment

@axic axic marked this pull request as ready for review June 9, 2020 12:19
@axic
Copy link
Member

axic commented Jun 9, 2020

@chfast okay to merge this if we ignore codecov?

@chfast
Copy link
Collaborator Author

chfast commented Jun 9, 2020

@chfast okay to merge this if we ignore codecov?

There are some issues with finding evmc-vmtester.

@axic
Copy link
Member

axic commented Jun 9, 2020

Btw in the ci branch I started updating to using newer cpp-build-env, but building WAVM fails with LLVM 6 not being installed. Perhaps those new build images are needed to get this one working?

@codecov-commenter
Copy link

Codecov Report

Merging #554 into master will increase coverage by 0.94%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   71.04%   71.98%   +0.94%     
==========================================
  Files           9        9              
  Lines        1554     1542      -12     
  Branches      137      136       -1     
==========================================
+ Hits         1104     1110       +6     
+ Misses        422      404      -18     
  Partials       28       28              

@axic
Copy link
Member

axic commented Jun 9, 2020

Verified with a local build of evmc-vmtester.

@axic axic merged commit c80bdd8 into master Jun 9, 2020
@axic axic deleted the evmc-v7 branch June 9, 2020 13:45
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2020

This pull request introduces 1 alert and fixes 1 when merging 71e7944 into cebfb99 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

fixed alerts:

  • 1 for FIXME comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants