Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the compiler #166

Merged
merged 11 commits into from
Aug 16, 2022
Merged

Documentation for the compiler #166

merged 11 commits into from
Aug 16, 2022

Conversation

arthurpaulino
Copy link
Member

@arthurpaulino arthurpaulino commented Aug 15, 2022

Addresses #158

@arthurpaulino arthurpaulino added the documentation Improvements or additions to documentation label Aug 15, 2022
@arthurpaulino arthurpaulino added this to the G1.M3 milestone Aug 15, 2022
@arthurpaulino arthurpaulino changed the title Documentation (more) Documentation for the compiler Aug 16, 2022
Comment on lines -120 to -122
| .lty lty => return match lty with
| .nat => "Nat"
| .str => "String"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Comment on lines -14 to -19
/-- There are only two types of literals -/
inductive LitType
| nat : LitType
| str : LitType
deriving BEq, Inhabited

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm seeing a pattern here lol. Are we removing LitType everywhere?

@winston-h-zhang winston-h-zhang marked this pull request as ready for review August 16, 2022 23:34
@winston-h-zhang winston-h-zhang merged commit b6f946f into main Aug 16, 2022
@winston-h-zhang winston-h-zhang deleted the ap/158-documentation branch August 16, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants