Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support for directly connected WAN HA #3720

Merged
merged 58 commits into from
Jun 21, 2024
Merged

Feat(eos_designs): Add support for directly connected WAN HA #3720

merged 58 commits into from
Jun 21, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 7, 2024 •
edited
Loading

Change Summary

This PR contains

  • new model for directly connected HA link
  • modification of eBGP LAN route-maps
  • Addition of iBGP session(s) between WAN HA peers using
  • Routes received from peer are set with Local Preference 50 to still prefer WAN routes

Pros of iBGP EVPN session:

  • This will support WAN HA in EVERY possible LAN scenario

Relies on #4107

PLEASE refer to internal documentation

Related Issue(s)

Discussion with CV Pathfinder team

Component(s) name

arista.avd.eos_designs

Proposed changes

cf summary

How to test

molecule + lab

Checklist

User Checklist

  • Update documentation

To discuss with reviewers

  • dhcp support for HA link
    -> not supported today
  • cross iBGP sessions
    -> only one direct link approved

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 7, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Mar 18, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 18, 2024
@gmuloc gmuloc marked this pull request as ready for review March 19, 2024 22:09
@gmuloc gmuloc requested review from a team as code owners March 19, 2024 22:09
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Mar 26, 2024
@gmuloc gmuloc marked this pull request as draft April 5, 2024 15:59
@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 20, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc marked this pull request as ready for review June 20, 2024 09:30
ClausHolbechArista
ClausHolbechArista requested changes Jun 21, 2024
View reviewed changes
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/shared_utils/wan.py Show resolved Hide resolved
gmuloc and others added 2 commits June 21, 2024 10:59
@gmuloc @ClausHolbechArista
Apply suggestions from code review
0751683 
Co-authored-by: Claus Holbech <holbech@arista.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6622990 
for more information, see https://pre-commit.ci
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 21, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 21, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

carlbuchmann
carlbuchmann approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit c71bcb2 into aristanetworks:devel Jun 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ayushmittal-arista ayushmittal-arista Awaiting requested review from ayushmittal-arista

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista