Fix(eos_designs)!: Remove eBGP LAN outbound route-map for WAN

[gmuloc]

Change Summary

The shipped eBGP LAN feature for WAN routers is not working for connected and static redistributed routes inside a VRF as the route-map would not match these routes. Similarly the routes coming from an eBGP peering in any VRF (including default) would be blocked out by the RM-BGP-UNDERLAY-PEERS-OUT route-map.

This PR is a breaking change to fix this situation.

Related Issue(s)

Discovered while working on #3720 and following review comments, separated in its own PR in order to be able to communicate with clarity about the breaking change.

Component(s) name

arista.avd.eos_design

Proposed changes

• Removing the outbound route-map for eBGP LAN peers on WAN routers
• Editing doc
• Adding limitation for eBGP peering in network_services received routes in VRF default that would not be advertised to the WAN.

How to test

molecule + test on existing lab

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4107
# Activate the virtual environment
source test-avd-pr-4107/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@breaking-ebgp-wan-ha#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,breaking-ebgp-wan-ha --force
# Optional: Install AVD examples
cd test-avd-pr-4107
ansible-playbook arista.avd.install_examples

[ClausHolbechArista]

So we are breaking the experimental HA behavior with this. But we have the real HA PR incoming so that is fine for me.

[carlbuchmann]

We should add a comment in the release notes about this breaking change.

[ClausHolbechArista]

Two minor comments to the release-notes

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[carlbuchmann]

LGTM