Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos_cli_config_gen: adding gnmi template and fixing TA config for CVaaS #432

Merged
merged 19 commits into from
Dec 8, 2020

Conversation

noredistribution
Copy link
Contributor

@noredistribution noredistribution commented Dec 7, 2020

Change Summary

Added management api gnmi template and fixed TerminAttr CVaaS config

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #430
Fixes #302

Component(s) name

Proposed changes

How to test

I've used the dc-fabric-deploy-cvp.yml playbook from https://github.com/arista-netdevops-community/ansible-webinar-february-2020

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation labels Dec 7, 2020
@titom73 titom73 added this to the v1.1.3 milestone Dec 7, 2020
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 8, 2020
@@ -1,7 +1,7 @@
!RANCID-CONTENT-TYPE: arista
!
daemon TerminAttr
exec /usr/bin/TerminAttr -cvaddr=apiserver.corp.arista.io:9910 -cvcompression=gzip -taillogs -cvauth=token-secure,/tmp/onboardingtoken1 -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -cvvrf=mgt
exec /usr/bin/TerminAttr -cvaddr=apiserver.corp.arista.io:443 -cvcompression=gzip -taillogs -cvauth=token-secure,/tmp/cv-onboarding-token -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -cvvrf=mgt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noredistribution please validate generated output!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's the correct config, works on my CVaaS tenant

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please validate CI output, and we can merge!

Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please build GNMI's documentation file as well ? In a similar way of PR #443

@github-actions github-actions bot added the state: conflict PR with conflict label Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 8, 2020
@titom73 titom73 self-requested a review December 8, 2020 21:15
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Conflicts have been resolved. A maintainer will review the pull request shortly.

@titom73 titom73 merged commit 101de43 into aristanetworks:devel Dec 8, 2020
@titom73 titom73 modified the milestones: v1.1.3, v1.1.2 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port and token path is incorrect for CVaaS config in TerminAttr template Add management api gnmi template
5 participants