-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eos_cli_config_gen: adding gnmi template and fixing TA config for CVaaS #432
eos_cli_config_gen: adding gnmi template and fixing TA config for CVaaS #432
Conversation
@@ -1,7 +1,7 @@ | |||
!RANCID-CONTENT-TYPE: arista | |||
! | |||
daemon TerminAttr | |||
exec /usr/bin/TerminAttr -cvaddr=apiserver.corp.arista.io:9910 -cvcompression=gzip -taillogs -cvauth=token-secure,/tmp/onboardingtoken1 -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -cvvrf=mgt | |||
exec /usr/bin/TerminAttr -cvaddr=apiserver.corp.arista.io:443 -cvcompression=gzip -taillogs -cvauth=token-secure,/tmp/cv-onboarding-token -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -cvvrf=mgt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noredistribution please validate generated output!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's the correct config, works on my CVaaS tenant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please validate CI output, and we can merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please build GNMI's documentation file as well ? In a similar way of PR #443
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
- Remove blank line when conditions are not met - Set default message when missing - Fix some rendering issues
- Update to support non-root user in container. - Update to pull image when stack is starting.
e754ce0
to
07cb611
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Change Summary
Added management api gnmi template and fixed TerminAttr CVaaS config
Types of changes
Related Issue(s)
Fixes #430
Fixes #302
Component(s) name
Proposed changes
How to test
I've used the
dc-fabric-deploy-cvp.yml
playbook from https://github.com/arista-netdevops-community/ansible-webinar-february-2020Checklist:
pre-commit
,make linting
andmake sanity-lint
).