Skip to content

refactor(eval): inject logger dependency into evaluators and runners#78

Merged
arittr merged 2 commits into8a076f-task-3-cli-integrationfrom
8a076f-task-4-eval-integration
Nov 3, 2025
Merged

refactor(eval): inject logger dependency into evaluators and runners#78
arittr merged 2 commits into8a076f-task-3-cli-integrationfrom
8a076f-task-4-eval-integration

Conversation

@arittr
Copy link
Owner

@arittr arittr commented Nov 3, 2025

  • Add logger parameter to ChatGPTAgent, MetaEvaluator, and SingleAttemptEvaluator constructors
  • Pass logger through EvalRunner and AttemptRunner to dependent components
  • Update all test files to inject SilentLogger into evaluator and runner instances
  • Update run-eval.ts to instantiate EvalRunner with ConsoleLogger
  • Remove direct console.log calls in favor of logger interface pattern

🤖 Generated with Claude via commitment

- Add logger parameter to ChatGPTAgent, MetaEvaluator, and SingleAttemptEvaluator constructors
- Pass logger through EvalRunner and AttemptRunner to dependent components
- Update all test files to inject SilentLogger into evaluator and runner instances
- Update run-eval.ts to instantiate EvalRunner with ConsoleLogger
- Remove direct console.log calls in favor of logger interface pattern

🤖 Generated with Claude via commitment
Implements:
- Updated prepare-commit-msg hook to check {2} parameter
- Hook only runs commitment when {2} is empty (regular commits)
- Preserves messages for git commit -m and merge commits
- Updated hook to use commands instead of jobs for consistency
- Added explanatory comments matching example hooks

Acceptance criteria met:
✅ lefthook.yml checks {2} parameter before running commitment
✅ git commit generates message (hook runs)
✅ git commit -m "test" preserves message (hook skips)
✅ Merge commits preserve messages (hook skips)
✅ commitment dogfooding still works
✅ Examples already correct (no changes needed)
@arittr arittr merged commit dc51173 into 8a076f-task-3-cli-integration Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments