refactor(eval): inject logger dependency into evaluators and runners#78
Merged
arittr merged 2 commits into8a076f-task-3-cli-integrationfrom Nov 3, 2025
Merged
Conversation
- Add logger parameter to ChatGPTAgent, MetaEvaluator, and SingleAttemptEvaluator constructors - Pass logger through EvalRunner and AttemptRunner to dependent components - Update all test files to inject SilentLogger into evaluator and runner instances - Update run-eval.ts to instantiate EvalRunner with ConsoleLogger - Remove direct console.log calls in favor of logger interface pattern 🤖 Generated with Claude via commitment
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Nov 3, 2025
Implements:
- Updated prepare-commit-msg hook to check {2} parameter
- Hook only runs commitment when {2} is empty (regular commits)
- Preserves messages for git commit -m and merge commits
- Updated hook to use commands instead of jobs for consistency
- Added explanatory comments matching example hooks
Acceptance criteria met:
✅ lefthook.yml checks {2} parameter before running commitment
✅ git commit generates message (hook runs)
✅ git commit -m "test" preserves message (hook skips)
✅ Merge commits preserve messages (hook skips)
✅ commitment dogfooding still works
✅ Examples already correct (no changes needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude via commitment