Skip to content

[Task 5] Fix lefthook.yml to preserve user commit messages#79

Merged
arittr merged 1 commit into8a076f-task-4-eval-integrationfrom
8a076f-task-5-hook-preservation-fix
Nov 3, 2025
Merged

[Task 5] Fix lefthook.yml to preserve user commit messages#79
arittr merged 1 commit into8a076f-task-4-eval-integrationfrom
8a076f-task-5-hook-preservation-fix

Conversation

@arittr
Copy link
Owner

@arittr arittr commented Nov 3, 2025

Implements:

  • Updated prepare-commit-msg hook to check {2} parameter
  • Hook only runs commitment when {2} is empty (regular commits)
  • Preserves messages for git commit -m and merge commits
  • Updated hook to use commands instead of jobs for consistency
  • Added explanatory comments matching example hooks

Acceptance criteria met:
✅ lefthook.yml checks {2} parameter before running commitment
✅ git commit generates message (hook runs)
✅ git commit -m "test" preserves message (hook skips)
✅ Merge commits preserve messages (hook skips)
✅ commitment dogfooding still works
✅ Examples already correct (no changes needed)

Implements:
- Updated prepare-commit-msg hook to check {2} parameter
- Hook only runs commitment when {2} is empty (regular commits)
- Preserves messages for git commit -m and merge commits
- Updated hook to use commands instead of jobs for consistency
- Added explanatory comments matching example hooks

Acceptance criteria met:
✅ lefthook.yml checks {2} parameter before running commitment
✅ git commit generates message (hook runs)
✅ git commit -m "test" preserves message (hook skips)
✅ Merge commits preserve messages (hook skips)
✅ commitment dogfooding still works
✅ Examples already correct (no changes needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments