Changing webpage settings should get immediate result

[iradul]

This will fix #13659
It will make sure that when page.settings property is changed it will take effect immediately.

[zackw]

Thanks for tackling this problem!

Unfortunately, we can't take your patch as is, because it changes a documented API and would break existing controller scripts. The third argument to page.openUrl needs to stay, even though it's no longer needed internally. Can you make that adjustment? It looks like it should be pretty simple.

Also, please consider writing some test cases.

[iradul]

Original page.openUrl is reverted back and I also added a simple test case.

[vitallium]

I got infinite recursion with this PR on creating a web page :(

[iradul]

Can you elaborate ?
For example this works perfectly fine after clean build, tested only on Windows though:

var page = require('webpage').create();
console.log( page.evaluate(function() { return navigator.userAgent; }) );
page.settings.userAgent = "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36";
console.log( page.evaluate(function() { return navigator.userAgent; }) ); 
page.open("http://google.com", function(status) {
    console.log(status);
    phantom.exit();
})

Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36
success

[rmehner]

We're running into the same issue (we need to be able to disable JavaScript for security reasons, and we use setContent). Is there anything I can do to help out with this to get this merged and into a PhantomJS release? :)