Fix settings #133

tomkooij · 2022-12-31T09:25:11Z

This tries to fix the settings pages for non-CVE devices
(Hopefully CVE devices as well, but I cannot test on CVE devices)

TODO:

Remove special case datatype 0x01
Implement "special case" datatype 0x0f (Float divider 2).
Fix signed floats. Cast ints to float according to datatype length (see: (WPU) setting (2410) type 0x01 seems wrong #129 (comment))
Support unsigned raw bytes to float, make identical to Fix unsigned floats #130
Test on WPU 5G fw37 fix WPU Heatpump settings incorrect #119 first
Test on Autotemp fw10
Test on CVE device (?)

Fixes #129
Fixes #126
Fixes #119

This "special case" seems erroneous. It breaks autotemp settings page.

Datatype 0x0f is a float from a single raw byte divided by 2. "is_float2"

float8: length "1" (single raw byte) with divider float16: length 2, with divider. float32: length 4, with divider.

tomkooij · 2022-12-31T09:27:22Z

This removes float2, float10 etc from settings and implements float8, float16, float32 according to raw byte length with a separate divisor. This is now more equal to status page handling of floats.

This could really use a refactor with a common function to convert raw bytes to int/uint/float.

Note that this treats all "floats" as signed raw bytes. I'll add a signed/unsigned to the TODO.

arjenhiemstra · 2023-01-04T16:45:09Z

Looks good and works fine on CVE devices

Use generic functions to handle datatypes

tomkooij · 2023-01-05T15:17:10Z

Unfortunately 2ac4bfa does not work correctly. Not all floats are casted to signed ints properly.
(Resulting in very large values instead of negative values).
This may not be a new bug, but it needs fixing anyway.

tomkooij · 2023-01-05T18:59:02Z

It seems casting "signed" raw bytes (negative values, 0x0000FC18 => -1000) to floats now works.

I'll do a more thorough check tomorrow.

Signed ints i.e. (0xfffffc18) = -1000 Must be cast from singed ints to float/double: static_cast<double>((int32_t) value);

Add 133 Reserved Add 177 Reserved

79 Blocking time heating to cooling 80 Blocking time cooling to heating 81 Min outdoor temp to change to cooling 82 Command test heating cooling

tomkooij · 2023-01-06T09:46:20Z

This seems to work, finally.

I added autotemp settings for fw12. but I have fw10... So that is untested. The settings are very desireable however, so I asked on Tweakers forum if someone has a fw12 autotemp.

arjenhiemstra · 2023-01-06T09:49:07Z

Great work, thanks!
Did you add the settings changes by hand?

tomkooij · 2023-01-06T09:50:33Z

Great work, thanks! Did you add the settings changes by hand?

Yes... painful work. Please don't tell me there is some kind of automation for this.

The WPU 5G v37 has 237 setting values. Hence, the index must be uint8_t not int8_t

tomkooij · 2023-01-06T12:41:50Z

Argh... Setting 179 on WPU is datatype 0x80 (signed 1byte integer).
It is not converted to signed value properly in the settings page (it does work on the debug page).

Some more work to do...

4 raw itho bytes are casted into an int64 to preserve sign and prevent overflows.

tomkooij · 2023-01-06T13:38:19Z

I seem to have catched and fixed the remaining overflow errors.

I merged this into the latest 2.4.4-beta4 and I'll try to use this "live" on my WPU and autotemp for a while and see if I can break it again. I cannot test changing all setting values, so that is still a bit untested. I did however test changing values that were previously broken.

int64_t cast_raw_bytes_to_int

WouterJN · 2023-01-06T17:15:07Z

Hi @tomkooij can you share a bin file that I can test? On version 2.4.4-beta4 at my WPU with WPUsetting9 some of my settings still look incorrect;

arjenhiemstra · 2023-01-06T17:54:04Z

I seem to have catched and fixed the remaining overflow errors.

I merged this into the latest 2.4.4-beta4 and I'll try to use this "live" on my WPU and autotemp for a while and see if I can break it again. I cannot test changing all setting values, so that is still a bit untested. I did however test changing values that were previously broken.

Thanks a lot! I’ll pull in this PR and test it somewhere after this weekend.

arjenhiemstra · 2023-01-06T17:54:41Z

Hi @tomkooij can you share a bin file that I can test? On version 2.4.4-beta4 at my WPU with WPUsetting9 some of my settings still look incorrect;

Beta4 does not include this PR, will be in beta5 somewhere next week

arjenhiemstra · 2023-01-09T23:18:19Z

This seems to work on my CVE and DemandFlow devices correctly, thanks for all the work!

tomkooij added 3 commits December 31, 2022 10:18

Remove special case 0x01

2ecbefe

This "special case" seems erroneous. It breaks autotemp settings page.

Special case datatype 0x0f

9b2393e

Datatype 0x0f is a float from a single raw byte divided by 2. "is_float2"

Implement float8 float16 float32

53a5081

float8: length "1" (single raw byte) with divider float16: length 2, with divider. float32: length 4, with divider.

tomkooij mentioned this pull request Jan 5, 2023

Fix unsigned floats #130

Merged

tomkooij added 3 commits January 5, 2023 11:03

Merge branch 'fix_signed_floats' into fix_settings

3c16009

Divider is uint32_t

03446cf

Refactor datatype handling for settings

2ac4bfa

Use generic functions to handle datatypes

tomkooij force-pushed the fix_settings branch from b0f6823 to 2ac4bfa Compare January 5, 2023 15:15

tomkooij force-pushed the fix_settings branch from a67b613 to 9d45ff9 Compare January 5, 2023 18:55

Fix casting signed ints to double

1142df1

Signed ints i.e. (0xfffffc18) = -1000 Must be cast from singed ints to float/double: static_cast<double>((int32_t) value);

tomkooij force-pushed the fix_settings branch from 9d45ff9 to 1142df1 Compare January 5, 2023 21:12

tomkooij added 2 commits January 5, 2023 22:43

Fix setting labels for WPU v33 v34 v37

cec5bb2

Add 133 Reserved Add 177 Reserved

Add autotemp settings for v12

56c6696

79 Blocking time heating to cooling 80 Blocking time cooling to heating 81 Min outdoor temp to change to cooling 82 Command test heating cooling

tomkooij force-pushed the fix_settings branch from a640ee8 to 56c6696 Compare January 6, 2023 09:43

Fix websocket.cpp float32 -> float + length

c2421a0

Settings index is uint_8t

401514a

The WPU 5G v37 has 237 setting values. Hence, the index must be uint8_t not int8_t

Use int64 for intermediate values

2825af5

4 raw itho bytes are casted into an int64 to preserve sign and prevent overflows.

Update header for cast_raw_bytes_to_int

63e4e64

int64_t cast_raw_bytes_to_int

arjenhiemstra merged commit 6cb218c into arjenhiemstra:master Jan 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix settings #133

Fix settings #133

tomkooij commented Dec 31, 2022 •

edited

Loading

tomkooij commented Dec 31, 2022 •

edited

Loading

arjenhiemstra commented Jan 4, 2023

tomkooij commented Jan 5, 2023

tomkooij commented Jan 5, 2023

tomkooij commented Jan 6, 2023

arjenhiemstra commented Jan 6, 2023

tomkooij commented Jan 6, 2023

tomkooij commented Jan 6, 2023

tomkooij commented Jan 6, 2023 •

edited

Loading

WouterJN commented Jan 6, 2023 •

edited

Loading

arjenhiemstra commented Jan 6, 2023

arjenhiemstra commented Jan 6, 2023

arjenhiemstra commented Jan 9, 2023 •

edited

Loading

Fix settings #133

Fix settings #133

Conversation

tomkooij commented Dec 31, 2022 • edited Loading

tomkooij commented Dec 31, 2022 • edited Loading

arjenhiemstra commented Jan 4, 2023

tomkooij commented Jan 5, 2023

tomkooij commented Jan 5, 2023

tomkooij commented Jan 6, 2023

arjenhiemstra commented Jan 6, 2023

tomkooij commented Jan 6, 2023

tomkooij commented Jan 6, 2023

tomkooij commented Jan 6, 2023 • edited Loading

WouterJN commented Jan 6, 2023 • edited Loading

arjenhiemstra commented Jan 6, 2023

arjenhiemstra commented Jan 6, 2023

arjenhiemstra commented Jan 9, 2023 • edited Loading

tomkooij commented Dec 31, 2022 •

edited

Loading

tomkooij commented Dec 31, 2022 •

edited

Loading

tomkooij commented Jan 6, 2023 •

edited

Loading

WouterJN commented Jan 6, 2023 •

edited

Loading

arjenhiemstra commented Jan 9, 2023 •

edited

Loading