Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export itho settings as json file #181

Closed
wants to merge 7 commits into from

Conversation

sanderkob
Copy link
Contributor

Ref. issue #63
When the button Download IthoSettings.json is pressed on the tho settings webpage, the webserver in task_web is triggered (/getithosettings).
This calls the function handleIthosettingsDownload(), where the Json array sumJson is called from getIthoSettingsBackupJSONPlus.
This array is then serialized and sent to the file IthoSettings.json (in the file system), a text file containing the settings in json format.
Then a download link is generated and the file is truncated for next use.
Download IthoSettings.json can only be operated after retrieval of settings (Retrieve settings button).
If desired the downloaded text file can be converted to a pdf table via https://wtools.io/convert-json-to-pdf.
This is a clean PR to replace PR #180

@stale
Copy link

stale bot commented Jun 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale closed No reaction on issue for a long time label Jun 28, 2023
@stale
Copy link

stale bot commented Jun 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this Jul 9, 2023
@arjenhiemstra arjenhiemstra reopened this Jan 4, 2024
@stale stale bot removed the stale closed No reaction on issue for a long time label Jan 4, 2024
@arjenhiemstra arjenhiemstra added enhancement New feature or request pinned Pinned labels Jan 4, 2024
@arjenhiemstra
Copy link
Owner

Thanks (finally!). It took some time before I could look at this very much wanted feature! In the end I choose to implement the idea a bit differently using only javascript and a browser based cache (localStorage) to achieve the same result.
The extra bonus is that reloading the settings page is now also instant.
See 2.7.0-beta1 for how this is implemented. Love to hear your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants