Skip to content

Commit

Permalink
reduce readinessProbe failureThreshold and periodSeconds (envoyproxy#…
Browse files Browse the repository at this point in the history 
…4021)

* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 67575b8)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
  • Loading branch information
@arkodg
arkodg committed Sep 7, 2024
1 parent 6a177c1 commit 1b33fc3
Show file tree
Hide file tree
Showing 32 changed files with 64 additions and 64 deletions.
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/resource.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,9 @@ func expectedProxyContainers(infra *ir.ProxyInfra,
},
},
TimeoutSeconds: 1,
PeriodSeconds: 10,
PeriodSeconds: 5,
SuccessThreshold: 1,
FailureThreshold: 3,
FailureThreshold: 1,
},
Lifecycle: &corev1.Lifecycle{
PreStop: &corev1.LifecycleHandler{
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/bootstrap.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/component-level.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/custom.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions ...rnal/infrastructure/kubernetes/proxy/testdata/deployments/custom_with_initcontainers.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default-env.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/disable-prometheus.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ spec:
name: EnvoyHTTPSPort
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/extension-env.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions ...infrastructure/kubernetes/proxy/testdata/deployments/override-labels-and-annotations.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/patch-deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/shutdown-manager.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/volumes.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-annotations.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-concurrency.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-extra-args.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-image-pull-secrets.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-node-selector.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions ...nfrastructure/kubernetes/proxy/testdata/deployments/with-topology-spread-constraints.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/resource.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ func expectedRateLimitContainers(rateLimit *egv1a1.RateLimit, rateLimitDeploymen
},
},
TimeoutSeconds: 1,
PeriodSeconds: 10,
PeriodSeconds: 5,
SuccessThreshold: 1,
FailureThreshold: 3,
FailureThreshold: 1,
},
},
}
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/custom.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/default-env.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/default.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/disable-prometheus.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/extension-env.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/override-env.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/ratelimit/testdata/deployments/patch-deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ spec:
name: grpc
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /healthcheck
port: 8080
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
Loading

0 comments on commit 1b33fc3

Please sign in to comment.