Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce readinessProbe failureThreshold and periodSeconds #4021

Merged
merged 1 commit into from
Aug 9, 2024
Merged

reduce readinessProbe failureThreshold and periodSeconds #4021

merged 1 commit into from
Aug 9, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 9, 2024 •
edited
Loading

Relates to #4002

@arkodg
reduce readinessProbe failureThreshold and periodSeconds
93590ac 
* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner August 9, 2024 01:21
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (b82f4b2) to head (93590ac).
Report is 89 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   67.59%   67.58%   -0.02%     
==========================================
  Files         185      185              
  Lines       22591    22591              
==========================================
- Hits        15271    15267       -4     
- Misses       6227     6229       +2     
- Partials     1093     1095       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor Author

arkodg commented Aug 9, 2024

cc @guydc @davidalger

@arkodg arkodg requested review from a team August 9, 2024 14:25
@arkodg arkodg merged commit 67575b8 into envoyproxy:main Aug 9, 2024
24 checks passed
@arkodg arkodg mentioned this pull request Aug 9, 2024
Open
@arkodg arkodg deleted the readiness-probe-shorter branch September 6, 2024 19:17
arkodg added a commit to arkodg/gateway that referenced this pull request Sep 7, 2024
@arkodg
reduce readinessProbe failureThreshold and periodSeconds (envoyproxy#…
cbd14ed 
…4021)

* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 67575b8)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Sep 7, 2024
Merged
arkodg added a commit to arkodg/gateway that referenced this pull request Sep 7, 2024
@arkodg
reduce readinessProbe failureThreshold and periodSeconds (envoyproxy#…
1b33fc3 
…4021)

* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 67575b8)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Sep 7, 2024
Closed
guydc pushed a commit that referenced this pull request Sep 10, 2024
@arkodg @qicz
@Xunzhuo @levikobi @ardikabs @liorokman @zirain @TasdidurRahman
[release/v1.1] Cherry-pick commits for v1.1.1 (#4173)
9a3f8f7 
* bugfix: fix upstream get unwanted /. (#3990)

* bugfix: fix upstream get unwanted /.

Signed-off-by: qicz <qiczzhu@gmail.com>

* ut for bugfix

Signed-off-by: qicz <qiczzhu@gmail.com>

---------

Signed-off-by: qicz <qiczzhu@gmail.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
(cherry picked from commit b77f6a4)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* feat: gateway http listener isolation (#4000)

Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
(cherry picked from commit 97830e9)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: multiple reference grants in same namespace (#4008)

* fix: multiple reference grants in same namespace

Signed-off-by: Ardika Bagus <me@ardikabs.com>

* test: add e2e test

Signed-off-by: Ardika Bagus <me@ardikabs.com>

* chore: wrong service port

Signed-off-by: Ardika Bagus <me@ardikabs.com>

---------

Signed-off-by: Ardika Bagus <me@ardikabs.com>
(cherry picked from commit b82f4b2)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* reduce readinessProbe failureThreshold and periodSeconds (#4021)

* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 67575b8)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: add header values as described in the documentation (#4031)

Add header values after splitting the provided value string on ',', like
described in the documentation.

Signed-off-by: Lior Okman <lior.okman@sap.com>
(cherry picked from commit eac30d6)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix ratelimit statsd not working (#4073)

fix ratelimit statd not working

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 6ab6482)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: active http healthcheck documents a default for expected status, but doesn't use it (#4090)

If no expected status was explicitly set, use the default value as
described in the documentation.

Signed-off-by: Lior Okman <lior.okman@sap.com>
(cherry picked from commit 0926b38)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* Fix IsNotFound check for secret and configmap (#4126)

fix IsNotFound check for secret and configmap

Signed-off-by: TasdidurRahman <tasdid@appscode.com>
(cherry picked from commit c20315f)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: assign sugar logger name. (#4144)

Signed-off-by: qicz <qiczzhu@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
(cherry picked from commit b50f5fa)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* use sets and return stable result (#4074)

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 6066f5a)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* delete internal/gatewayapi/clustersettings.go NA for v1.1

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* bump to go1.22.7 (#4175)

* bump to go1.22.6

Signed-off-by: zirain <zirain2009@gmail.com>

* bump to 1.22.7

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 69bf882)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: qicz <qiczzhu@gmail.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
Signed-off-by: Ardika Bagus <me@ardikabs.com>
Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
Co-authored-by: qi <qiczzhu@gmail.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
Co-authored-by: Kobi Levi <56400138+levikobi@users.noreply.github.com>
Co-authored-by: Ardika <me@ardikabs.com>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Tasdidur Rahman <52253951+TasdidurRahman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@cnvergence cnvergence cnvergence approved these changes

Assignees
No one assigned
Labels
cherrypick/release-v1.0.3 cherrypick/release-v1.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkodg @zirain @cnvergence