Completing helm charts + Basic Auth for server #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added a service account that has no rolebindings etc as this is better practice than using the "default" serviceaccount Some people may add lots of permissions to their default serviceaccount and this application doesn't need any. So this gives us more control, making sure it has the permissions we want it to (no kubernetes access)
- Removed "executor" top level from values.yaml as typically you don't wrap everything in a top level - Changed the chart name from executor to armada-executor
Accidentally armada-executor is being tagged as the armada component Therefore we never publish component and publish the armada-executor component twice
It seemed like a good idea to have all images from the same branch have the same name. It saved space However kubernetes caches images based on name, meaning if the images have the same name (tag) then it is annoying to get kubernetes to load the newest image The SHA means all branch images are unique, so it is easy to know which tag you are pulling exactly We'll just add stricter cleanup for branch images in our repository
…netes Specifying port to expose on pod - This was accidentally omitted, meaning the pod never exposed any port Specifying TLS path + ingress details in ingress.yaml - NGINX only supports GRPC with TLS enabled currently. It will terminate the TLS for us however
This is to prevent just anyone being able to access the service and uses Basic Auth to valid users. - Using a really crude implementation with in-memory map of users. - The thought is we'll replace this with tokens and never use this implementation in prod, this is just to secure it more on AWS for now - Lays the "groundwork" for proper auth, with authentication structure in place (interceptors etc)
Now the api expects basic auth (when enabled) the executor component has been updated to be able to provide basic auth in its requests
Now if you supply a username/password, we'll armadactl will contact the api with TLS enabled + basic auth. Otherwise it'll continue to use plain connection with no auth details. Swapped to using viper for all variables, to be more consistent with "normal" and our other components Loading config from files now, when provided (default is $HOME/.armadactl.yaml
This allows you to set the users, which is an unexposed field, by using this "constructor" func
…name This is to make it consistent with the related definition executor.config.name
…t fixes handshake issues In theory we are not using a cert for either, so I would expect the same result but they appear to use different code paths
JamesMurkin
changed the title
jankaspar
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should replace Basic Auth pretty soon with some cert based authentication.
For now this was quick and works and should set the groundwork for any other auth system we use (i.e passing in secrets file, reading secrets file etc).
We just want something quick to prevent unknown people using our system while it is deployed in AWS