-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completing helm charts + Basic Auth for server #47
Commits on Aug 7, 2019
-
Adding helm chart for armada (API) component
I have added a service account that has no rolebindings etc as this is better practice than using the "default" serviceaccount Some people may add lots of permissions to their default serviceaccount and this application doesn't need any. So this gives us more control, making sure it has the permissions we want it to (no kubernetes access)
Configuration menu - View commit details
-
Copy full SHA for 3d38472 - Browse repository at this point
Copy the full SHA 3d38472View commit details -
Minor changes to armada-executor helm chart
- Removed "executor" top level from values.yaml as typically you don't wrap everything in a top level - Changed the chart name from executor to armada-executor
Configuration menu - View commit details
-
Copy full SHA for 39c86ef - Browse repository at this point
Copy the full SHA 39c86efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e1b11f - Browse repository at this point
Copy the full SHA 9e1b11fView commit details -
Configuration menu - View commit details
-
Copy full SHA for aea1d09 - Browse repository at this point
Copy the full SHA aea1d09View commit details
Commits on Aug 9, 2019
-
Fixing which image is pushed to "armada" repo
Accidentally armada-executor is being tagged as the armada component Therefore we never publish component and publish the armada-executor component twice
Configuration menu - View commit details
-
Copy full SHA for a261037 - Browse repository at this point
Copy the full SHA a261037View commit details
Commits on Aug 12, 2019
-
Adding SHA to branch build image names
It seemed like a good idea to have all images from the same branch have the same name. It saved space However kubernetes caches images based on name, meaning if the images have the same name (tag) then it is annoying to get kubernetes to load the newest image The SHA means all branch images are unique, so it is easy to know which tag you are pulling exactly We'll just add stricter cleanup for branch images in our repository
Configuration menu - View commit details
-
Copy full SHA for 1761c5f - Browse repository at this point
Copy the full SHA 1761c5fView commit details -
Small adjustments to armada helm chart so they work properly in kuber…
…netes Specifying port to expose on pod - This was accidentally omitted, meaning the pod never exposed any port Specifying TLS path + ingress details in ingress.yaml - NGINX only supports GRPC with TLS enabled currently. It will terminate the TLS for us however
Configuration menu - View commit details
-
Copy full SHA for 1909520 - Browse repository at this point
Copy the full SHA 1909520View commit details -
Adding basic auth to armada api component
This is to prevent just anyone being able to access the service and uses Basic Auth to valid users. - Using a really crude implementation with in-memory map of users. - The thought is we'll replace this with tokens and never use this implementation in prod, this is just to secure it more on AWS for now - Lays the "groundwork" for proper auth, with authentication structure in place (interceptors etc)
Configuration menu - View commit details
-
Copy full SHA for b38633b - Browse repository at this point
Copy the full SHA b38633bView commit details -
Adding basic auth to executor component
Now the api expects basic auth (when enabled) the executor component has been updated to be able to provide basic auth in its requests
Configuration menu - View commit details
-
Copy full SHA for 69f2df3 - Browse repository at this point
Copy the full SHA 69f2df3View commit details -
Adding Basic Auth capability to armadactl component
Now if you supply a username/password, we'll armadactl will contact the api with TLS enabled + basic auth. Otherwise it'll continue to use plain connection with no auth details. Swapped to using viper for all variables, to be more consistent with "normal" and our other components Loading config from files now, when provided (default is $HOME/.armadactl.yaml
Configuration menu - View commit details
-
Copy full SHA for 97003c4 - Browse repository at this point
Copy the full SHA 97003c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7316fac - Browse repository at this point
Copy the full SHA 7316facView commit details -
Adding New function for BasicAuthAuthorizeService
This allows you to set the users, which is an unexposed field, by using this "constructor" func
Configuration menu - View commit details
-
Copy full SHA for 58bbc91 - Browse repository at this point
Copy the full SHA 58bbc91View commit details -
Renaming executor.application.config.filename to executor.config.file…
…name This is to make it consistent with the related definition executor.config.name
Configuration menu - View commit details
-
Copy full SHA for a5a4091 - Browse repository at this point
Copy the full SHA a5a4091View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ba0cbf - Browse repository at this point
Copy the full SHA 5ba0cbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 216cd8d - Browse repository at this point
Copy the full SHA 216cd8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc5d123 - Browse repository at this point
Copy the full SHA cc5d123View commit details -
Configuration menu - View commit details
-
Copy full SHA for 119e274 - Browse repository at this point
Copy the full SHA 119e274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19aa1c6 - Browse repository at this point
Copy the full SHA 19aa1c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0899db3 - Browse repository at this point
Copy the full SHA 0899db3View commit details -
Swapping to using NewTLS rather than NewClientTLSFromCert to see if i…
…t fixes handshake issues In theory we are not using a cert for either, so I would expect the same result but they appear to use different code paths
Configuration menu - View commit details
-
Copy full SHA for 8cbfe95 - Browse repository at this point
Copy the full SHA 8cbfe95View commit details
Commits on Aug 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 610f91c - Browse repository at this point
Copy the full SHA 610f91cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3265d77 - Browse repository at this point
Copy the full SHA 3265d77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d1a7d2 - Browse repository at this point
Copy the full SHA 1d1a7d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d5bca0 - Browse repository at this point
Copy the full SHA 4d5bca0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d243431 - Browse repository at this point
Copy the full SHA d243431View commit details