Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing helm charts + Basic Auth for server #47

Merged
merged 25 commits into from
Aug 13, 2019
Merged

Completing helm charts + Basic Auth for server #47

merged 25 commits into from
Aug 13, 2019

Commits on Aug 7, 2019

  1. Adding helm chart for armada (API) component

    I have added a service account that has no rolebindings etc as this is better practice than using the "default" serviceaccount
    
    Some people may add lots of permissions to their default serviceaccount and this application doesn't need any.
    So this gives us more control, making sure it has the permissions we want it to (no kubernetes access)
    JamesMurkin committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    3d38472 View commit details
    Browse the repository at this point in the history
  2. Minor changes to armada-executor helm chart

     - Removed "executor" top level from values.yaml as typically you don't wrap everything in a top level
     - Changed the chart name from executor to armada-executor
    JamesMurkin committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    39c86ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e1b11f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aea1d09 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Fixing which image is pushed to "armada" repo

    Accidentally armada-executor is being tagged as the armada component
    
    Therefore we never publish component and publish the armada-executor component twice
    JamesMurkin committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    a261037 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Adding SHA to branch build image names

    It seemed like a good idea to have all images from the same branch have the same name. It saved space
    
    However kubernetes caches images based on name, meaning if the images have the same name (tag) then it is annoying to get kubernetes to load the newest image
    
    The SHA means all branch images are unique, so it is easy to know which tag you are pulling exactly
    
    We'll just add stricter cleanup for branch images in our repository
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    1761c5f View commit details
    Browse the repository at this point in the history
  2. Small adjustments to armada helm chart so they work properly in kuber…

    …netes
    
    Specifying port to expose on pod
     - This was accidentally omitted, meaning the pod never exposed any port
    Specifying TLS path + ingress details in ingress.yaml
     - NGINX only supports GRPC with TLS enabled currently. It will terminate the TLS for us however
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    1909520 View commit details
    Browse the repository at this point in the history
  3. Adding basic auth to armada api component

    This is to prevent just anyone being able to access the service and uses Basic Auth to valid users.
     - Using a really crude implementation with in-memory map of users.
     - The thought is we'll replace this with tokens and never use this implementation in prod, this is just to secure it more on AWS for now
     - Lays the "groundwork" for proper auth, with authentication structure in place (interceptors etc)
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b38633b View commit details
    Browse the repository at this point in the history
  4. Adding basic auth to executor component

    Now the api expects basic auth (when enabled) the executor component has been updated to be able to provide basic auth in its requests
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    69f2df3 View commit details
    Browse the repository at this point in the history
  5. Adding Basic Auth capability to armadactl component

    Now if you supply a username/password, we'll armadactl will contact the api with TLS enabled + basic auth.
    
    Otherwise it'll continue to use plain connection with no auth details.
    
    Swapped to using viper for all variables, to be more consistent with "normal" and our other components
    
    Loading config from files now, when provided (default is $HOME/.armadactl.yaml
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    97003c4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7316fac View commit details
    Browse the repository at this point in the history
  7. Adding New function for BasicAuthAuthorizeService

    This allows you to set the users, which is an unexposed field, by using this "constructor" func
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    58bbc91 View commit details
    Browse the repository at this point in the history
  8. Renaming executor.application.config.filename to executor.config.file…

    …name
    
    This is to make it consistent with the related definition executor.config.name
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    a5a4091 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5ba0cbf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    216cd8d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    cc5d123 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    119e274 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    19aa1c6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0899db3 View commit details
    Browse the repository at this point in the history
  15. Swapping to using NewTLS rather than NewClientTLSFromCert to see if i…

    …t fixes handshake issues
    
    In theory we are not using a cert for either, so I would expect the same result but they appear to use different code paths
    JamesMurkin committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    8cbfe95 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Configuration menu
    Copy the full SHA
    610f91c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3265d77 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d1a7d2 View commit details
    Browse the repository at this point in the history
  4. Minor cleanup

    JamesMurkin committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    4d5bca0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d243431 View commit details
    Browse the repository at this point in the history