-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cli: uboot: Include PYTHONPATH in env for compiling U-Boot
- Also group all u-boot make environment variables together for easier maintainability - Fixes u-boot requiring `pyelftools` - Fixes commit 04f619d
- Loading branch information
1 parent
d29305a
commit 792d9d9
Showing
1 changed file
with
14 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://paste.armbian.com/qemexoqaka
/armbian/cache/sources/u-boot-worktree/u-boot/v2022.04/./tools/binman/binman:12: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
from distutils.sysconfig import get_python_lib
/armbian/cache/sources/u-boot-worktree/u-boot/v2022.04/./tools/binman/binman:12: DeprecationWarning: The distutils.sysconfig module is deprecated, use sysconfig instead
from distutils.sysconfig import get_python_lib
Traceback (most recent call last):
File "/armbian/cache/sources/u-boot-worktree/u-boot/v2022.04/./tools/binman/binman", line 38, in
from binman import bintool
File "/armbian/cache/sources/u-boot-worktree/u-boot/v2022.04/tools/binman/bintool.py", line 44, in
DOWNLOAD_DESTDIR = os.path.join(os.getenv('HOME'), 'bin')
File "/usr/lib/python3.10/posixpath.py", line 76, in join
a = os.fspath(a)
TypeError: expected str, bytes or os.PathLike object, not NoneType
make: *** [Makefile:1094: all] Error 1
probably related to this.
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igorpecovnik @ColorfulRhino I just forced a rebuild of all my uboots, a few dozen, incl tinkerboard. Tinkerboard was the only one to fail. What's special about it?
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It boots the device, working UMS support IIRC, ...
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely not what I meant.
There is some specific issue here, probably with 22.04 u-boot (using thus old binman) and newer python packages that @ColorfulRhino introduced.
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, misunderstand it. Yes, ofc.
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm building 496 (!) u-boot's to check. https://github.com/armsurvivors/armbian-release/actions/runs/9732618446/job/26858514768
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing! I will investigate.
Very nice 😄
It seems that only Tinkerboard and xt-q8l (?) is failing because 2022.04 uses an old binman. Khadad Vim3 seems to fail for some other unrelated (?) reason.
Maybe easiest would be to bump the uboot version on those two boards.
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a
lukefor
userpatched thing I have, ignore it.Yeah, but maybe it's unadvertently using binman? Maybe we can bump, but maybe we can make it not-use binman if that proves too complex. (I don't have any 32-bit boards).
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm not sure why it's using binman.
The version for those two boards is defined here:
build/config/sources/families/rockchip.conf
Lines 26 to 27 in ec8c470
I could check later if simply bumping this version and moving the patches is enough or if there's any patch conflicts, and then @paolosabatino could test since I don't have any of those boards as well.
But if you can find out the "not use binman" part, that's fine too :)
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check, after learning wth
UBOOT_TARGET_MAP
means again792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a fix 🎉 will PR soon
792d9d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6845