u-boot: add HOME env for make invocations to avoid binman/Python problems with older u-boot versions #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lems with older u-boot versions
- this avoids trouble building certain older versions with binman
- as it tries to `os.path.join(os.getenv('HOME'), 'bin')` and gets a `None` and dies
- naming names: `tinkerboard` & `xt-q8l-v10` (BOARDFAMILY=rockchip), which _actually use_ binman & 22.04 combo
github-actions
bot
added
size/large
|
@paolosabatino the rewrites were done as part of investigation into the completely innocent The trouble being fixed here is unrelated to rk3328, except for the fact it's the only family simultaneously on 22.04 and using binman. |
rpardini
referenced
this pull request
Jun 30, 2024
- Also group all u-boot make environment variables together for easier maintainability - Fixes u-boot requiring `pyelftools` - Fixes commit 04f619d
|
Trouble was detected by Igor here and was actually introduced by the |
igorpecovnik
added
Ready to merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u-boot: add HOME env for make invocations to avoid binman/Python problems with older u-boot versions
os.path.join(os.getenv('HOME'), 'bin')and gets aNoneand diestinkerboard&xt-q8l-v10(BOARDFAMILY=rockchip), which actually use binman & 22.04 combo