Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RK3588 edge: Add H.264 decoder support #6734

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

@ColorfulRhino ColorfulRhino commented Jun 12, 2024

Description

Add a patch series to support VEPU121/VPU121, which mainly enables hardware decoding for H.264. It can also decode MPEG2 and VP8 as well as do JPEG encoding.

Usually I am against bloating the kernel with patches since it makes it more difficult to maintain. But having access to the RK3588's H.264 decoder is really useful for day to day tasks.

How Has This Been Tested?

  • Build success: ./compile.sh BOARD=nanopi-r6c BRANCH=edge RELEASE=trixie EXPERT=yes KERNEL_CONFIGURE=no BUILD_MINIMAL=no BUILD_DESKTOP=no EXTRAWIFI=no kernel
  • Needs some testing

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... labels Jun 12, 2024
Copy link
Contributor

@amazingfate amazingfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColorfulRhino
Copy link
Collaborator Author

ColorfulRhino commented Jun 13, 2024

Won't this conflict with this patch? https://github.com/armbian/build/blob/main/patch%2Fkernel%2Farchive%2Frockchip-rk3588-6.10%2F0147-arm64-dts-rockchip-rk3588-add-VDPU-and-RGA2-nodes.patch

Yes of course it does, I had forgotten that one. Fixed, thanks!

@efectn
Copy link
Member

efectn commented Jun 13, 2024

Add a patch series to support VEPU121/VPU121, which mainly enables hardware decoding for H.264.
It can also decode MPEG2 and VP8 as well as do JPEG encoding.
Remove vpu nodes from RGA patch since these are already included in the H.264 support patch.
@ColorfulRhino
Copy link
Collaborator Author

FYI: New version of the patch is here https://lore.kernel.org/all/20240613135034.31684-1-sebastian.reichel@collabora.com/

Yes, I was about to send this updated version while you were writing the comment. Thanks 😄

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jun 14, 2024
@ColorfulRhino ColorfulRhino merged commit bc8ee48 into armbian:main Jun 14, 2024
11 checks passed
@ColorfulRhino ColorfulRhino deleted the rk3588-h264 branch June 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

4 participants