Remove usage of deprecated CDI API. #104
Conversation
|
Since Travis is deprecated, I have also added the GH Actions template to this PR but apparently it won't trigger any runs until the file has been merged into master. The build itself works locally so I expect no issue with that. |
|
@starksm64 @bartoszmajsak I could use a review here and eventually a release on this project :) |
| @@ -0,0 +1,34 @@ | |||
| name: Arquillian Weld Container CI | |||
There was a problem hiding this comment.
Any particular reason for GH action vs Circle CI? It's good to see .travis.yml problem being solved [1], I just wonder if we should strive for having a unified CI view and maintenance for the whole org (with the downside being shared quotas for example) or leave freedom to choose for every project.
[1] on a personal level I'm a bit sad about what happened to this milestone in CI space after acquisition though :(
There was a problem hiding this comment.
Good point, I didn't even think about it. I used GH actions throughout Weld projects so I automatically added it here as well.
I am only familiar with Travis (whose free version was a joke last time I checked) and with GH Actions which has fairly astonishing throughput and limits for free usage. So I am biased towards GH actions :-)
I don't know CircleCI and what ups/downs it has but if you prefer it, I can change it - your call.
There was a problem hiding this comment.
I checked the how-to setup for CircleCI but it seems it requires admin to set it up on their website which I cannot do either way. But maybe there is another way I missed.
@bartoszmajsak let me know how you want to proceed - if you are fine with GH actions, I think we can merge it as-is. If you want CircleCI, I can withdraw GH actions changes from this PR.
There was a problem hiding this comment.
I think we can stick with it if that works for you. Gonna push the release buttons today :)
Fixes #103
Latest CDI API (4.0.0.Alpha1) removed some long deprecated API.
Therefore, using this container will cause a failure with
NoSuchMethod- spotted as part of weld/core#2383Not to be merged until there is a release of Arq. core that contains arquillian/arquillian-core#339