Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDIInjectionEnricher uses deprecated BeanManager method, switch to a … #339

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Jun 9, 2021

…replacement.

Fixes #338

@manovotn
Copy link
Contributor Author

manovotn commented Jun 9, 2021

The CI failure seems unrelated but I am unable to re-start the job from their UI.

Ladicek
Ladicek previously approved these changes Jun 9, 2021
@manovotn
Copy link
Contributor Author

manovotn commented Jun 11, 2021

Added a commit that similarly changes the behavior for the old javax variant of the enricher.

Reason is that I found out WFLY still uses the old one for its Arq. adapter - https://github.com/wildfly/wildfly-arquillian/blob/master/common/pom.xml#L38
And this adapter is then (if my understanding is correct) transformed for EE 9+ purposes. Which means using it for my testing, I will run into exact same issue.
The update in this PR bumps the CDI dependency on the old one from 1.0 (which is dead since forever) to 1.2 (which is only about a century old now) and can then achieve the same trick. It should be pretty harmless.

EDIT: forgot to update Weld version for testing, should be fixed now.

Ladicek
Ladicek previously approved these changes Jun 11, 2021
@manovotn
Copy link
Contributor Author

@bartoszmajsak a review would be much appreciated when you have some spare time. And eventually a release ;-)

@starksm64 starksm64 merged commit 9ce9ccf into arquillian:master Jun 16, 2021
@bartoszmajsak
Copy link
Member

@manovotn 1.7.0.Alpha10 is out in the official JBoss repo, should be in central later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDIInjectionEnricher uses deprecated, and in latest version removed, API
4 participants