Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jakarta): introduces locks to avoid race conditions #321

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Mar 6, 2021

Fixes #319

added locks and signalling to correctly cancel timers so no stale ope…rations

are called to undeployed applications

@lprimak
Copy link
Contributor Author

lprimak commented Mar 9, 2021

Payara JIRA QACI-638

@@ -214,6 +231,8 @@ public void run() {
}
} catch (Exception e) {
e.printStackTrace();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a little bit concerning, but that's not part of this PR anyway ;)

Copy link
Member

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

@bartoszmajsak bartoszmajsak changed the title Fixes Race conditions in ServletMethodExecutor fix(jakarta): introduces locks to avoid race conditions Mar 22, 2021
@bartoszmajsak bartoszmajsak merged commit f5dbd56 into arquillian:master Mar 22, 2021
@lprimak lprimak deleted the ServletMethodExecutorRace branch March 22, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race conditions in ServletMethodExecutor when doing parallel testing
2 participants