Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(testng): reworks thread locals causing TestNG Parallel issues #322

Merged
merged 5 commits into from
Mar 22, 2021
Merged

fix(testng): reworks thread locals causing TestNG Parallel issues #322

merged 5 commits into from
Mar 22, 2021

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Mar 6, 2021

Fixes #320

@lprimak lprimak marked this pull request as ready for review March 6, 2021 03:12
@lprimak
Copy link
Contributor Author

lprimak commented Mar 9, 2021

Payara JIRA QACI-638

@lprimak
Copy link
Contributor Author

lprimak commented Mar 18, 2021

Any chance to get this one and #321 merged @bartoszmajsak please?

bartoszmajsak
bartoszmajsak reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this code looks cleaner and seemingly works ;)

I just shared two comments for your consideration.

testng/core/src/main/java/org/jboss/arquillian/testng/Arquillian.java Show resolved Hide resolved
testng/core/src/main/java/org/jboss/arquillian/testng/Arquillian.java Show resolved Hide resolved
@lprimak lprimak requested a review from bartoszmajsak March 22, 2021 19:33
bartoszmajsak
bartoszmajsak approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will cut the release.

thank-you

@bartoszmajsak bartoszmajsak changed the title Fixes TestNG Parallel test issues fix(testng): reworks thread locals causing TestNG Parallel issues Mar 22, 2021
@bartoszmajsak bartoszmajsak merged commit 14271ca into arquillian:master Mar 22, 2021
@lprimak
Copy link
Contributor Author

lprimak commented Mar 22, 2021

yay! thank you!

@lprimak lprimak deleted the TestNGParallel branch March 22, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszmajsak bartoszmajsak bartoszmajsak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestNG driver fails when doing parallel testing
2 participants
@lprimak @bartoszmajsak