Bump kotest #188
Bump kotest #188
Conversation
There was a problem hiding this comment.
@aballano , thanks!! In summary: I'd just upgrade arrow-core-test which is using KotlinTest now as a compile dependency and Gradle finds and replaces arrow-core dependency by project dependency. That shouldn't happen in the rest of libraries where just removing exclude Arrow should work.
This reverts commit 0be3002.
Fix Arb combine
build.gradle
Outdated
| tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all { | ||
| kotlinOptions { | ||
| jvmTarget = "1.8" | ||
| } | ||
| } |
There was a problem hiding this comment.
Awesome job in this PR 👏 Please, could you locate these lines in arrow repository? subprojects section in generic-conf.gradle. JAVA_VERSION is available. Thanks!!
|
@aballano, the checks are going to find https://github.com/arrow-kt/arrow-fx/tree/ab/bump-kotest branch because arrow-kt/arrow-fx#230 is open. Close that PR in order not to consider that branch during checks (I think it's not fixed yet). |
# Conflicts: # arrow-core-data/src/test/kotlin/arrow/core/ConstTest.kt # arrow-core-data/src/test/kotlin/arrow/core/EitherTest.kt # arrow-core-data/src/test/kotlin/arrow/core/ValidatedTest.kt
| @@ -1,9 +1,6 @@ | |||
| @file:Suppress("NAME_SHADOWING") | |||
| package arrow.core | |||
|
|
|||
| inline fun <A, R> mapN(a: A?, fn: (A) -> R): R? = | |||
There was a problem hiding this comment.
Why these changes unrelated to PR?
# Conflicts: # arrow-core-data/src/test/kotlin/arrow/core/IorTest.kt # arrow-core-test/src/main/kotlin/arrow/core/test/generators/Generators.kt
|
@aballano Can we consider this ticket in TODO with this PR? |
# Conflicts: # arrow-core-data/src/test/kotlin/arrow/core/BooleanTest.kt # arrow-core-data/src/test/kotlin/arrow/core/ConstTest.kt # arrow-core-data/src/test/kotlin/arrow/core/IdTest.kt # arrow-core-data/src/test/kotlin/arrow/core/IorTest.kt # arrow-core-data/src/test/kotlin/arrow/core/ListKTest.kt # arrow-core-data/src/test/kotlin/arrow/core/NonEmptyListTest.kt # arrow-core-data/src/test/kotlin/arrow/core/OptionTest.kt # arrow-core-data/src/test/kotlin/arrow/core/SequenceKTest.kt # arrow-core-data/src/test/kotlin/arrow/core/ValidatedTest.kt # arrow-core-data/src/test/kotlin/arrow/core/extensions/NumberInstancesTest.kt # arrow-core-data/src/test/kotlin/arrow/core/extensions/StringInstancesTest.kt
# Conflicts: # arrow-core-test/src/main/kotlin/arrow/core/test/generators/GenK.kt # arrow-core-test/src/main/kotlin/arrow/core/test/generators/Generators.kt # arrow-core-test/src/main/kotlin/arrow/core/test/laws/HashLaws.kt
No description provided.