This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Nullable mapN #189
Merged
Nullable mapN #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballano
suggested changes
Jul 21, 2020
Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com>
nomisRev
approved these changes
Jul 22, 2020
|
Very nice work @tapegram! Thanks and congrats for your first contribution 👏 👏 👏 🎉 🎉 🎉 |
This was referenced Jul 23, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#159
Implemented mapN for up to 9. Tried to minimize the differences in implementation so lower arity's reuses higher arity implementations. IMO, it would have been ideal to implement this with partial application, where each arg of
fnis applied as it is determined to not be null, and just short-circuiting with null otherwise, but I'm not sure if that is currently possible to implement in a reasonable way.