This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Clean up arrow-fx-test #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
reviewed
Mar 5, 2020
|
|
||
| fun <A> A.equalUnderTheLaw(b: A, eq: Eq<A>): Boolean = | ||
| eq.run { eqv(b) } | ||
|
|
||
| fun <A> A.shouldBeEq(b: A, eq: Eq<A>): Unit = this should matchUnderEq(eq, b) |
There was a problem hiding this comment.
Shouldn't all this file belong in arrow-core-test?
There was a problem hiding this comment.
Yes, had this here because I wanted to see if this even compiles before moving it
| @@ -24,14 +25,14 @@ class FiberTest : UnitSpec() { | |||
|
|
|||
| init { | |||
| fun EQ(): Eq<FiberOf<ForIO, Int>> = object : Eq<FiberOf<ForIO, Int>> { | |||
There was a problem hiding this comment.
Can we move these to arrow-fx-test as well and unfix them to ForIO?
Fine by me. This fails to compile for reasons I don't understand^^ Wanted to take a look at it this weekend, but if you want to try it go ahead :) |
Merged
|
This is continued in #90 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a bunch of duplicate code.
This fails building with gradle locally because it can't find the generators for some reason. Intellij fails to shows this as an error and I don't even understand why it'd fail^^
Edit: I also changed
arrow-fx-testto be published the same way asarrow-core-test