Cleanup fx tests #90

danimontoya · 2020-03-06T15:10:41Z

Continues the work done in #51 :
Removes a bunch of duplicate code.

This fails building with gradle locally because it can't find the generators for some reason. Intellij fails to shows this as an error and I don't even understand why it'd fail^^

Edit: I also changed arrow-fx-test to be published the same way as arrow-core-test

1Jajen1 · 2020-03-06T23:32:44Z

Is this a redo of #51 ? If so I'll close that and stop trying to figure out what was broken since this one actually compiles^^ 👍

danimontoya · 2020-03-07T00:14:07Z

Yes sorry I did not tell you yet.. but was being hard to make it work and updating #51 😅
I'll ping you when its done to have a look! thanks!

1Jajen1 · 2020-03-07T00:20:10Z

Yes sorry I did not tell you yet.. but was being hard to make it work and updating #51 sweat_smile
I'll ping you when its done to have a look! thanks!

No problem, just got a bit confused. Glad to see this compiling^^

# Conflicts: # arrow-fx/src/test/kotlin/arrow/fx/IOTest.kt

nomisRev

Great work @danimontoya 👏 👏 Happy to see it green! 🎉

I left some comments in regard to where things can be moved to give them more meaningful locations so people can also depend on them if they want. arrow-fx-test will also make it more worthwhile to write better utilities that can be shared.

Schedule and Resource also have Eq, EqK, Gen, GenK and Gen2 implementations that can be moved to arrow-fx-test.

nomisRev · 2020-03-07T09:05:23Z

arrow-fx-test/src/main/kotlin/arrow/test/eq/EqK.kt

+ }
+}
+
+fun <F, A> EQ(EQ: Eq<Kind<F, A>>): Eq<FiberOf<F, A>> = object : Eq<FiberOf<F, A>> {


Suggested change

fun <F, A> EQ(EQ: Eq<Kind<F, A>>): Eq<FiberOf<F, A>> = object : Eq<FiberOf<F, A>> {

fun <F, A> Fiber.Companion.eq(EQ: Eq<Kind<F, A>>): Eq<FiberOf<F, A>> = object : Eq<FiberOf<F, A>> {

We can also add an EqK instance for Fiber.

nomisRev · 2020-03-07T09:09:34Z

arrow-fx-test/src/main/kotlin/arrow/test/generators/Generators.kt

+ gen.map(IO.Companion::just),
+ Gen.throwable().map(IO.Companion::raiseError)
+ )
+}


GenK of Fiber can also be moved here

nomisRev · 2020-03-07T09:10:06Z

arrow-fx-test/src/main/kotlin/arrow/test/generators/Generators.kt

- }
+fun <A, B> Gen.Companion.functionABToB(gen: Gen<B>): Gen<(A, B) -> B> = gen.map { b: B -> { _: A, _: B -> b } }
+
+fun <A> Gen<A>.genEval(): Gen<Eval<A>> =


Eval comes from arrow.core.

nomisRev · 2020-03-07T09:12:08Z

arrow-fx-test/src/main/kotlin/arrow/test/laws/Law.kt

 import io.kotlintest.properties.Gen
 import io.kotlintest.should
 import io.kotlintest.shouldNot

+// TODO: check to move to arrow-core-test
 fun throwableEq() = Eq { a: Throwable, b ->


I am okay leaving this in arrow-fx-test since effects imply Throwable, and comparing Throwable can be dependent on use-case. Let's move this with the other Eq instances tho.

I think this is a fair implementation to leave public in arrow-fx-test, but we should add a clear KDoc that comparing Throwable is not safe due to their structure (stacktrace), so we structurally compare type and message instead.

nomisRev · 2020-03-07T09:12:45Z

arrow-fx/src/test/kotlin/arrow/fx/FiberTest.kt

- override fun FiberOf<ForIO, Int>.eqv(b: FiberOf<ForIO, Int>): Boolean = EQ<Int>().run {
- fix().join().eqv(b.fix().join())
- }
- }

 fun EQK() = object : EqK<FiberPartialOf<ForIO>> {


See other comment, move to arrow-fx-test.

nomisRev · 2020-03-07T11:01:34Z

arrow-fx-test/build.gradle

 compile "io.arrow-kt:arrow-mtl:$VERSION_NAME", excludeArrow
- compile "io.arrow-kt:arrow-mtl-data:$VERSION_NAME", excludeArrow
 compile "io.arrow-kt:arrow-free:$VERSION_NAME", excludeArrow


Suggested change

compile "io.arrow-kt:arrow-free:$VERSION_NAME", excludeArrow

We don't need free in arrow-fx-test

nomisRev · 2020-03-07T11:02:23Z

arrow-fx-test/build.gradle


 dependencies {
 compile project(":arrow-fx")
- compile "io.arrow-kt:arrow-core-test:$VERSION_NAME", excludeArrow
+ api "io.arrow-kt:arrow-core-test:$VERSION_NAME", excludeArrow
 compile "io.arrow-kt:arrow-mtl:$VERSION_NAME", excludeArrow


We don't need mtl in arrow-fx-test

nomisRev · 2020-03-07T11:05:52Z

arrow-fx-test/build.gradle

 compile "io.arrow-kt:arrow-free:$VERSION_NAME", excludeArrow
- compile "io.arrow-kt:arrow-free-data:$VERSION_NAME", excludeArrow
- compile "io.arrow-kt:arrow-recursion-data:$VERSION_NAME", excludeArrow
 compile "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$KOTLIN_VERSION"
 compile "org.jetbrains.kotlinx:kotlinx-coroutines-core:$KOTLINX_COROUTINES_VERSION"


Created #93 for the removal of this dependency. This is low priority so not blocking for 0.10.x

…nflicting with it Move EQK and GENK from FiberTest to EqK and GeneratorsFx Clean up dependencies not used

arrow-fx-test/src/main/kotlin/arrow/test/eq/EqK.kt

rachelcarmena

Awesome job!! 🎉

nomisRev · 2020-03-10T08:08:31Z

Unblocks arrow-kt/arrow-incubator#63

danimontoya added 2 commits March 6, 2020 16:09

draft cleanup fx tests

270736f

draft cleanup fx tests

88b78f2

1Jajen1 mentioned this pull request Mar 7, 2020

Clean up arrow-fx-test #51

Closed

danimontoya added 3 commits March 7, 2020 03:05

some more cleanup

1da81dd

Merge branch 'master' into dm-fx-tests-cleanup

748a71d

# Conflicts: # arrow-fx/src/test/kotlin/arrow/fx/IOTest.kt

merge master

9dd6e98

nomisRev reviewed Mar 7, 2020

View reviewed changes

danimontoya changed the title ~~temporary draft cleanup fx tests~~ Cleanup fx tests Mar 9, 2020

Rename Generators from fx because somehow Generators from core was co…

61e418f

…nflicting with it Move EQK and GENK from FiberTest to EqK and GeneratorsFx Clean up dependencies not used

rachelcarmena suggested changes Mar 9, 2020

View reviewed changes

arrow-fx-test/src/main/kotlin/arrow/test/eq/EqK.kt Outdated Show resolved Hide resolved

danimontoya added 3 commits March 9, 2020 22:48

Fix imports after renaming arrow.core.test

b0bd5af

Rename arrow.test to arrow.fx.test in arrow-fx-test module

a3384ec

Move some eqK genK

bc5a5c2

danimontoya marked this pull request as ready for review March 9, 2020 23:12

danimontoya requested a review from rachelcarmena March 9, 2020 23:12

rachelcarmena approved these changes Mar 10, 2020

View reviewed changes

rachelcarmena merged commit 99c6226 into master Mar 10, 2020

rachelcarmena deleted the dm-fx-tests-cleanup branch March 10, 2020 07:47

danimontoya mentioned this pull request Mar 10, 2020

Remove unneeded KotlinX Coroutines within arrow fx test #97

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup fx tests #90

Cleanup fx tests #90

danimontoya commented Mar 6, 2020 •

edited

Loading

1Jajen1 commented Mar 6, 2020

danimontoya commented Mar 7, 2020

1Jajen1 commented Mar 7, 2020

nomisRev left a comment

nomisRev Mar 7, 2020

nomisRev Mar 7, 2020

nomisRev Mar 7, 2020

nomisRev Mar 7, 2020

nomisRev Mar 7, 2020

nomisRev Mar 7, 2020 •

edited

Loading

nomisRev Mar 7, 2020

nomisRev Mar 7, 2020

rachelcarmena left a comment

nomisRev commented Mar 10, 2020

	fun <F, A> EQ(EQ: Eq<Kind<F, A>>): Eq<FiberOf<F, A>> = object : Eq<FiberOf<F, A>> {
	fun <F, A> Fiber.Companion.eq(EQ: Eq<Kind<F, A>>): Eq<FiberOf<F, A>> = object : Eq<FiberOf<F, A>> {

Cleanup fx tests #90

Cleanup fx tests #90

Conversation

danimontoya commented Mar 6, 2020 • edited Loading

1Jajen1 commented Mar 6, 2020

danimontoya commented Mar 7, 2020

1Jajen1 commented Mar 7, 2020

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

nomisRev Mar 7, 2020 • edited Loading

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

nomisRev Mar 7, 2020

Choose a reason for hiding this comment

rachelcarmena left a comment

Choose a reason for hiding this comment

nomisRev commented Mar 10, 2020

danimontoya commented Mar 6, 2020 •

edited

Loading

nomisRev Mar 7, 2020 •

edited

Loading