Recommend Either.getOrElse for handleError instead of recover #2986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommending
getOrElse
forhandleError
gives a better flowing of types than usingEither<Nothing, A>
,and is more in line with the changes made in Removes autobind DSL in favor of getOrElse.
recover
is a replacement forhandleErrorWith
and using it forhandleError
(sadly) results in poor inference, because@BuilderInference
doesn't inferNothing
whenEE
is not used.