Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend Either.getOrElse for handleError instead of recover #2986

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Recommend Either.getOrElse for handleError instead of recover #2986

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b6e854
Recommend getOrElse for handleError
nomisRev Mar 17, 2023
d1a902a
Update deprecation message
nomisRev Mar 17, 2023
d5af595
Merge branch 'main' into replacewith-handleerror-getorelse
franciscodr Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2274,15 +2274,12 @@ public inline fun <A, B, C> Either<A, B>.handleErrorWith(f: (A) -> Either<C, B>)
}

@Deprecated(
RedundantAPI + "Prefer the new recover API",
ReplaceWith(
"this.recover<A, Nothing, B> { f(it) }",
"arrow.core.recover"
)
RedundantAPI + "Prefer resolving the error with getOrElse.",
ReplaceWith("getOrElse(f).right()", "arrow.core.right", "arrow.core.getOrElse")
)
public inline fun <A, B> Either<A, B>.handleError(f: (A) -> B): Either<A, B> {
contract { callsInPlace(f, InvocationKind.AT_MOST_ONCE) }
return recover { a -> f(a) }
return getOrElse(f).right()
}

@Deprecated(
Expand Down