Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identifier search to ArchivesSpace/ATK upload #261

Merged
merged 2 commits into from
Aug 7, 2015
Merged

Add identifier search to ArchivesSpace/ATK upload #261

merged 2 commits into from
Aug 7, 2015

Conversation

mistydemeo
Copy link
Contributor

No description provided.

@qubot qubot force-pushed the dev/issue-8695-identifier_search branch from 066c551 to fbfcdb7 Compare July 28, 2015 20:32
Hwesta
Hwesta reviewed Jul 28, 2015
View reviewed changes
src/archivematicaCommon/lib/archivistsToolkit/client.py

params = tuple(params)

sql = "SELECT resourceId FROM Resources WHERE ({}) AND resourceLevel in ('recordgrp', 'collection') ORDER BY title".format(clause)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why format in the clause, instead of adding to params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The params are SQL placeholders; they're not string interpolation, but rather passing parameters to stored procedures. Since this isn't a single value it can't be passed in the params that way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, okay. And because this is being considered for an external library you don't want to use an ORM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so. Converting this to use the ORM would be some extra work, especially since we don't have control over the ATK database structure (and the ATK stuff is happening in a separate database from Archivematica).

@Hwesta
Copy link
Contributor

Hwesta commented Jul 28, 2015

Tests for new functionality?

@qubot qubot force-pushed the dev/issue-8695-identifier_search branch from fbfcdb7 to 9a18d36 Compare July 28, 2015 22:26
@mistydemeo
Copy link
Contributor Author

Added ASpace tests.

@Hwesta
Copy link
Contributor

Hwesta commented Jul 28, 2015

👍

@Hwesta Hwesta modified the milestone: 1.5.0 Jul 28, 2015
@Hwesta Hwesta mentioned this pull request Jul 28, 2015
Merged
@qubot qubot force-pushed the dev/issue-8695-identifier_search branch from 9a18d36 to 07a8d5b Compare August 5, 2015 00:08
@mistydemeo
Copy link
Contributor Author

Updated to make the search UI clearer.

@qubot qubot force-pushed the dev/issue-8695-identifier_search branch from 07a8d5b to 7087f1b Compare August 7, 2015 19:26
@qubot qubot force-pushed the dev/issue-8695-identifier_search branch from 7087f1b to f6ac582 Compare August 7, 2015 19:26
@qubot qubot merged commit f6ac582 into qa/1.x Aug 7, 2015
@qubot qubot deleted the dev/issue-8695-identifier_search branch August 7, 2015 19:27
@replaceafill replaceafill self-assigned this Dec 11, 2019
@replaceafill replaceafill added the Status: in progress Issue that is currently being worked on. Waffle label. label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@replaceafill replaceafill

Labels
Status: in progress Issue that is currently being worked on. Waffle label.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mistydemeo @Hwesta @replaceafill @qubot