Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArchivesSpace: Automate matching GUI #258

Merged
merged 9 commits into from
Aug 10, 2015
Merged

ArchivesSpace: Automate matching GUI #258

merged 9 commits into from
Aug 10, 2015

Conversation

Hwesta
Copy link
Contributor

@Hwesta Hwesta commented Jul 9, 2015

Automatically parse an archivesspacesids.csv and populate the matching GUI for archivesspace.

  • Do not automatically open the matching GUI
  • Add DIP generation helper to Prepare DIP that parses archivesspaceids.csv for filename,reference ID, queries ArchivesSpace for the resource ID associated with the reference identifier, and populates ArchivesSpaceDIPObjectResourcePairing

mistydemeo
mistydemeo reviewed Jul 14, 2015
View reviewed changes
src/MCPClient/lib/clientScripts/dip_generation_helper.py

rc = 0

rc = rc or parse_archivesspace_ids(args.sipPath, args.sipUUID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this exits 0 on success, can you just sys.exit(parse_archivesspace_ids(args.sipPath, args.sipUUID))?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this script would be used for multiple DIP helpers, and the script should return failure if any one of them failed, so the RC should be the or'd results of all the helpers. Does this seem reasonable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Maybe leave a comment to that effect (since it's not clear when there aren't yet multiple values to or), or do that when there is more than one exit code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mistydemeo
Copy link
Contributor

👍 Tests are nice to see too :D

@qubot qubot force-pushed the dev/issue-8609-automate-matching-gui branch from 57f9e1e to 362ecce Compare July 14, 2015 18:15
@Hwesta Hwesta modified the milestone: 1.5.0 Jul 15, 2015
@qubot qubot force-pushed the dev/issue-8609-automate-matching-gui branch from 362ecce to 77050dc Compare July 15, 2015 22:16
@Hwesta
Copy link
Contributor Author

Hwesta commented Jul 24, 2015

Note: this is in the process of getting updated other ArchivesSpace enhancements (tickets #8697 and #8696 in Redmine)

@qubot qubot force-pushed the dev/issue-8609-automate-matching-gui branch 2 times, most recently from e776f86 to 559d9e5 Compare July 28, 2015 23:06
@Hwesta
Copy link
Contributor Author

Hwesta commented Jul 28, 2015

Now based on top of #261

Added 0d065ec

@qubot qubot force-pushed the dev/issue-8609-automate-matching-gui branch from 9dfd688 to f5e1baf Compare August 5, 2015 00:06
@Hwesta
Dashboard: AS/ATK cleanup
a860675 
Remove unused function, use messages for form confirmation, update ATK config
saving to match AS, format template.
@Hwesta
ArchivesSpace: Minor fixes
94fc502
@Hwesta
ArchivesSpace: Do not open matching GUI with JS
c2cc8f6
@Hwesta
ArchivesSpace: Add query by field function
604e4f3 
Add function to return a resource based on an exact query by a specific field.
@Hwesta
Add helper to collect all metadata files
7200efd 
Helper searches transfer and SIP metadata directories for all copies of a
file with the provided filename.
@Hwesta
DIP: Add DIP generation helper skeleton
488a32f 
Helper to generate information needed by the DIP that is only available in
the SIP. E.g. parsing metadata files.
@Hwesta
ArchivesSpace: Parse archivesspaceids.csv for filename->resource ID
9d01fd7
@Hwesta
ArchivesSpace: Provide access file size & format info
1bf9a9c 
refs #8696

When uploading to ArchivesSpace, also upload the access file's size and
format name.  file_format_name is a restricted vocabulary and should be
configured in ArchivesSpace first so upload succeeds.
@Hwesta
ArchivesSpace: add subjects & agents to children
59c822c 
refs #8697
@qubot qubot force-pushed the dev/issue-8609-automate-matching-gui branch from f5e1baf to 59c822c Compare August 7, 2015 20:27
@qubot qubot merged commit 59c822c into qa/1.x Aug 10, 2015
@qubot qubot deleted the dev/issue-8609-automate-matching-gui branch August 10, 2015 23:53
@Hwesta Hwesta mentioned this pull request Jan 25, 2016
Closed
@replaceafill replaceafill self-assigned this Dec 6, 2019
@replaceafill replaceafill added the Status: in progress Issue that is currently being worked on. Waffle label. label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@replaceafill replaceafill

Labels
Status: in progress Issue that is currently being worked on. Waffle label.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Hwesta @mistydemeo @replaceafill @qubot