Revert "ArchivesSpace: Do not open matching GUI with JS" #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2cc8f6. After some discussion, we determined that this was not the best solution to the problem at this point in time. We don't have a clear UI that drives users to this feature, so expecting users to know to click on the small clipboard icon seems liable to result in a great deal of confusion. This shouldn't affect most automation users, as Holly suggests they may well not notice the popup is there or even have the dashboard UI open at the point at which it would be triggered. Fixes #9347.
|
Another reason I'd like to revert this is that the ATK matching GUI still does auto-open, and I'd like to avoid feature drift between the two otherwise very similar workflows where possible. |
|
👍 |
|
The original change was in #258 |
|
@mistydemeo Did this only get pushed to github, not the internal gitolite? It disappeared when another branch got pushed, and gitolite synced to github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c2cc8f6.
After some discussion, we determined that this was not the best solution to the problem at this point in time. We don't have a clear UI that drives users to this feature, so expecting users to know to click on the small clipboard icon seems liable to result in a great deal of confusion.
This shouldn't affect most automation users, as Holly suggests they may well not notice the popup is there or even have the dashboard UI open at the point at which it would be triggered.
Fixes #9347.