Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BS5 Theme: review/update required form elements #1687

Closed
phalene-bytes opened this issue Oct 25, 2023 · 0 comments · Fixed by #1686
Closed

BS5 Theme: review/update required form elements #1687

phalene-bytes opened this issue Oct 25, 2023 · 0 comments · Fixed by #1686
Assignees
@phalene-bytes @melaniekung
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.8.0

Comments

@phalene-bytes
Copy link
Contributor

phalene-bytes commented Oct 25, 2023 •
edited
Loading

Form elements for BS5 that are noted as required (*) can create the * span element using the

  • lib/form/arB5WidgetFormSchemaFormatter.class.php

BS2 used:

  • plugins/sfDrupalPlugin/lib/sfDrupalWidgetFormSchemaFormatter.class.php

The asterisk should show up as orange in BS5 because the primary-text class is added, but is showing up as gray in some form elements.
Example:
Screenshot 2023-10-24 at 9 32 27 PM

For this example, the * span element has directly added the BS2 format:
image

This difference is happening in several places, so need to review and update.
@phalene-bytes phalene-bytes self-assigned this Oct 25, 2023
@melaniekung melaniekung transferred this issue from another repository Oct 25, 2023
@melaniekung melaniekung linked a pull request Oct 25, 2023 that will close this issue
Standardize BS5 required form elements. (#61) #1686
Merged
@melaniekung melaniekung added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels Oct 25, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Oct 25, 2023
phalene-bytes added a commit that referenced this issue Oct 28, 2023
@phalene-bytes
Update BS5 required form elements #1687
181d96a
phalene-bytes added a commit that referenced this issue Oct 30, 2023
@phalene-bytes
Update BS5 required form elements #1687
44ceeb1
phalene-bytes added a commit that referenced this issue Oct 30, 2023
@phalene-bytes
Update BS5 required form elements (#1687)
8c6630d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phalene-bytes phalene-bytes

@melaniekung melaniekung

Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Standardize BS5 required form elements. (#61) artefactual/atom
2 participants
@phalene-bytes @melaniekung