Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize BS5 required form elements. (#61) #1686

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Standardize BS5 required form elements. (#61) #1686

merged 1 commit into from
Nov 20, 2023

Conversation

melaniekung
Copy link
Contributor

The asterisk used to represent required fields in BS5 forms should consistently be orange.

@melaniekung melaniekung requested a review from a team October 25, 2023 19:14
@melaniekung melaniekung self-assigned this Oct 25, 2023
@melaniekung melaniekung added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels Oct 25, 2023
@melaniekung melaniekung added this to the 2.8.0 milestone Oct 25, 2023
@melaniekung melaniekung linked an issue Oct 25, 2023 that may be closed by this pull request
BS5 Theme: review/update required form elements #1687
Closed
@melaniekung melaniekung marked this pull request as draft October 25, 2023 20:04
@melaniekung
Copy link
Contributor Author

@phalene-bytes is investigating a solution to the base issue rather than a patch up fix

@melaniekung melaniekung marked this pull request as ready for review November 20, 2023 21:08
@melaniekung melaniekung merged commit 9bb130a into qa/2.x Nov 20, 2023
@melaniekung melaniekung deleted the dev/issue-61-bs5-form-required-elements branch November 20, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraddaoui jraddaoui jraddaoui approved these changes

Assignees

@melaniekung melaniekung

Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

BS5 Theme: review/update required form elements
2 participants
@melaniekung @jraddaoui