Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ghaction-import-gpg to v5.1.0 #70

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Jul 31, 2022

artichoke/ghaction-import-gpg is synced from upstream which includes several new releases, including a breaking change to v5 which upgrades the nodejs runtime version.

The tag in artichoke/ghaction-import-gpg is:

Diff of the upgrade from v4.1.0 to v5.1.0 is:

The diff is mostly tests and linting, with some changes to how key fingerprints and subkeys are handled, most notably:

artichoke/nightly uses a signing subkey, so these fixes are good to take.

`artichoke/ghaction-import-gpg` is synced from upstream which includes
several new releases, including a breaking change to v5 which upgrades
the nodejs runtime version.

The tag in `artichoke/ghaction-import-gpg` is:

- https://github.com/artichoke/ghaction-import-gpg/tree/v5.1.0

Diff of the upgrade from v4.1.0 to v5.1.0 is:

- https://github.com/artichoke/ghaction-import-gpg/compare/v4.1.0..v5.1.0.

The diff is mostly tests and linting, with some changes to how key
fingerprints and subkeys are handled, most notably:

- crazy-max/ghaction-import-gpg#123
- crazy-max/ghaction-import-gpg#125
- crazy-max/ghaction-import-gpg#129

`artichoke/nightly` uses a signing subkey, so these fixes are good to
take.
@lopopolo lopopolo added A-deps Area: Source and library dependencies. A-codesigning Area: Code signing, GPG signatures. labels Jul 31, 2022
@lopopolo lopopolo merged commit f8f856c into trunk Jul 31, 2022
@lopopolo lopopolo deleted the lopopolo/gpg-ghaction-upgrade branch July 31, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codesigning Area: Code signing, GPG signatures. A-deps Area: Source and library dependencies.
Development

Successfully merging this pull request may close these issues.

1 participant