Delete key using the primary key ID not the subkey ID #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 81.96% 81.96%
=======================================
Files 3 3
Lines 122 122
Branches 25 25
=======================================
Hits 100 100
Misses 11 11
Partials 11 11 Continue to review full report at Codecov.
|
|
Can you rebase? |
josecelano
force-pushed
the
delete-key-using-key-id
branch
from
b0c1320
to
a7fb0ed
Compare
josecelano
force-pushed
the
delete-key-using-key-id
branch
from
a7fb0ed
to
6ebc729
Compare
lopopolo
added a commit
to artichoke/nightly
that referenced
this pull request
Jul 31, 2022
`artichoke/ghaction-import-gpg` is synced from upstream which includes several new releases, including a breaking change to v5 which upgrades the nodejs runtime version. The tag in `artichoke/ghaction-import-gpg` is: - https://github.com/artichoke/ghaction-import-gpg/tree/v5.1.0 Diff of the upgrade from v4.1.0 to v5.1.0 is: - https://github.com/artichoke/ghaction-import-gpg/compare/v4.1.0..v5.1.0. The diff is mostly tests and linting, with some changes to how key fingerprints and subkeys are handled, most notably: - crazy-max/ghaction-import-gpg#123 - crazy-max/ghaction-import-gpg#125 - crazy-max/ghaction-import-gpg#129 `artichoke/nightly` uses a signing subkey, so these fixes are good to take.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #124
As I've explained in that issue. The command to delete the key at the end of the workflow fails. It's failing because it's using the fingerprint of the subkey. I think you cannot delete only a subkey and you have to use either a name or the fingerprint of the primary key.
I've changed the code to store the KeyID in the state together with the fingerprint used, in order to use the primary key fingerprint.
I've not tested yet if that works.