[SE(3)] Add setters for translation and rotation #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#167 should fix the windows |
artivis
requested changes
Sep 2, 2020
artivis
reviewed
Sep 2, 2020
GiulioRomualdi
force-pushed
the
feature/add_setters_SE3
branch
from
396c287
to
a8a4ab8
Compare
Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com>
Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com>
GiulioRomualdi
force-pushed
the
feature/add_setters_SE3
branch
from
a8a4ab8
to
fdc59ef
Compare
Codecov Report
@@ Coverage Diff @@
## devel #166 +/- ##
==========================================
+ Coverage 98.23% 98.24% +0.01%
==========================================
Files 37 37
Lines 1132 1142 +10
==========================================
+ Hits 1112 1122 +10
Misses 20 20 |
artivis
approved these changes
Sep 2, 2020
artivis
reviewed
Sep 2, 2020
… method Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com>
|
Alright, looks good. Thanks for iterating 👍 |
mindbeast
pushed a commit
to mindbeast/manif
that referenced
this pull request
Sep 13, 2020
* [SE3] Implement the setters for translation and quaternion * [SE3] Implement a test for the quaternion and translation setters * [SE(3)] Fix style in SE3_base.h file Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com> * [SE(3)] Avoid code duplication in SE3::quat() method Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com> * [SE(3)] Avoid creating temporary quaternion object in SE3Base::quat() method Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com> Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the setters for the SE(3) object. Specifically, it implements two functions
quat()andtranslation()to set the rotation and the translation to an already existing SE(3) object.The
quat()methods checks if the quaternion has unitary norm, if not an exception is thrown.This PR closes #160