-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update splash screen logic #10808
Conversation
c44b9ec
to
0b5758d
Compare
|
||
RNBootSplash.init(this, R.style.BootTheme); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had to refactor this file on the rn bump pr to be kotlin but I bet that bootsplash will have this line for kotlin as well, you might wanna rebase to test it out again
cbc129c
to
085a141
Compare
Please let me know if there is something I can adjust here - I tested this locally and everything seemed fine for me. I will create betas as well to test things further |
69a0f87
to
bf58bad
Compare
src/app/AppRegistry.tsx
Outdated
@@ -495,6 +496,12 @@ export const modules = defineModules({ | |||
HomeContainer, | |||
{ | |||
isRootViewForTabName: "home", | |||
screenOptions: { | |||
statusBarColor: "red", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
red? dev change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oupsie
} | ||
if (isLoggedIn && Platform.OS === "android") { | ||
ArtsyNativeModule.setNavigationBarColor(DEFAULT_NAVIGATION_BAR_COLOR) | ||
ArtsyNativeModule.setAppLightContrast(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styling and orientation lock no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, a couple questions about some removed code I wasn't clear on. Thanks!
Description
This PR makes the following changes:
react-native-bootsplash
to the latest version on both Android and iOS.react-native-bootsplash
and dismiss the splash screen from the JS side.PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.