chore: update splash screen logic #10808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/upgrade-rn-splash-screen
branch
from
c44b9ec
to
0b5758d
Compare
gkartalis
reviewed
Sep 20, 2024
Comment on lines
58
to
60
|
|
||
| RNBootSplash.init(this, R.style.BootTheme); | ||
|
|
There was a problem hiding this comment.
we had to refactor this file on the rn bump pr to be kotlin but I bet that bootsplash will have this line for kotlin as well, you might wanna rebase to test it out again
MounirDhahri
force-pushed
the
feat/upgrade-rn-splash-screen
branch
from
cbc129c
to
085a141
Compare
|
Please let me know if there is something I can adjust here - I tested this locally and everything seemed fine for me. I will create betas as well to test things further |
MounirDhahri
force-pushed
the
feat/upgrade-rn-splash-screen
branch
from
69a0f87
to
bf58bad
Compare
src/app/AppRegistry.tsx
Outdated
| @@ -495,6 +496,12 @@ export const modules = defineModules({ | |||
| HomeContainer, | |||
| { | |||
| isRootViewForTabName: "home", | |||
| screenOptions: { | |||
| statusBarColor: "red", | |||
| } | ||
| if (isLoggedIn && Platform.OS === "android") { | ||
| ArtsyNativeModule.setNavigationBarColor(DEFAULT_NAVIGATION_BAR_COLOR) | ||
| ArtsyNativeModule.setAppLightContrast(false) |
There was a problem hiding this comment.
styling and orientation lock no longer necessary?
brainbicycle
previously approved these changes
Sep 25, 2024
MounirDhahri
added
the
Squash On Green
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following changes:
react-native-bootsplashto the latest version on both Android and iOS.react-native-bootsplashand dismiss the splash screen from the JS side.PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.