feat: render new Homeview for artsy people #10851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
commented
Sep 26, 2024
| @@ -499,8 +498,7 @@ export const modules = defineModules({ | |||
| screenOptions: { | |||
| statusBarTranslucent: true, | |||
| }, | |||
| fullBleed: | |||
| ArtsyNativeModule.isBetaOrDev && !unsafe_getFeatureFlag("ARPreferLegacyHomeScreen"), | |||
| fullBleed: true, | |||
There was a problem hiding this comment.
I tested the screens after this change to make sure I didn't break anything
Screen.Recording.2024-09-26.at.17.30.16.mov
MounirDhahri
commented
Sep 26, 2024
|
|
||
| const shouldDisplayNewHomeView = ArtsyNativeModule.isBetaOrDev && !preferLegacyHomeScreen | ||
| const shouldDisplayNewHomeView = | ||
| (isArtsyEmployee || ArtsyNativeModule.isBetaOrDev) && !preferLegacyHomeScreen |
There was a problem hiding this comment.
We want to keep the old logic + the condition of having an artsymail account account
There was a problem hiding this comment.
Wondering if this check is now out of sync with this one, which was added previously in #10808
eigen/src/app/utils/useHideSplashScreen.ts
Lines 16 to 18 in 1448580
Any cause for concern? I.e. will Artsy users on the app store versions miss out on any pre-fetching?
dblandin
reviewed
Sep 26, 2024
| @@ -499,8 +498,7 @@ export const modules = defineModules({ | |||
| screenOptions: { | |||
| statusBarTranslucent: true, | |||
| }, | |||
| fullBleed: | |||
| ArtsyNativeModule.isBetaOrDev && !unsafe_getFeatureFlag("ARPreferLegacyHomeScreen"), | |||
| fullBleed: true, | |||
dblandin
approved these changes
Sep 26, 2024
|
|
||
| const shouldDisplayNewHomeView = ArtsyNativeModule.isBetaOrDev && !preferLegacyHomeScreen | ||
| const shouldDisplayNewHomeView = | ||
| (isArtsyEmployee || ArtsyNativeModule.isBetaOrDev) && !preferLegacyHomeScreen |
MounirDhahri
added
the
Squash On Green
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1330
Description
This PR exposes the new homeview to artsy people.
For easier review, I suggest you hide white spaces
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.