-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render new Homeview for artsy people #10851
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ import { | |
WorksForYouScreenQuery, | ||
} from "app/Components/Containers/WorksForYou" | ||
import { FadeIn } from "app/Components/FadeIn" | ||
import { ArtsyNativeModule } from "app/NativeModules/ArtsyNativeModule" | ||
import { ActivityItemScreenQueryRenderer } from "app/Scenes/Activity/ActivityItemScreen" | ||
import { ArtQuiz } from "app/Scenes/ArtQuiz/ArtQuiz" | ||
import { ArtQuizResults } from "app/Scenes/ArtQuiz/ArtQuizResults/ArtQuizResults" | ||
|
@@ -143,7 +142,7 @@ import { | |
ViewingRoomsListScreen, | ||
viewingRoomsListScreenQuery, | ||
} from "./Scenes/ViewingRoom/ViewingRoomsList" | ||
import { GlobalStore, unsafe_getFeatureFlag } from "./store/GlobalStore" | ||
import { GlobalStore } from "./store/GlobalStore" | ||
import { propsStore } from "./store/PropsStore" | ||
import { DevMenu } from "./system/devTools/DevMenu/DevMenu" | ||
import { Schema, screenTrack } from "./utils/track" | ||
|
@@ -499,8 +498,7 @@ export const modules = defineModules({ | |
screenOptions: { | ||
statusBarTranslucent: true, | ||
}, | ||
fullBleed: | ||
ArtsyNativeModule.isBetaOrDev && !unsafe_getFeatureFlag("ARPreferLegacyHomeScreen"), | ||
fullBleed: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome 💯 |
||
}, | ||
[homeViewScreenQuery] | ||
), | ||
|
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -15,8 +15,10 @@ export const InnerHomeContainer = () => { | |||||||
const showPlayground = useDevToggle("DTShowPlayground") | ||||||||
|
||||||||
const preferLegacyHomeScreen = useFeatureFlag("ARPreferLegacyHomeScreen") | ||||||||
const isArtsyEmployee = GlobalStore.useAppState((state) => state.auth.userHasArtsyEmail) | ||||||||
|
||||||||
const shouldDisplayNewHomeView = ArtsyNativeModule.isBetaOrDev && !preferLegacyHomeScreen | ||||||||
const shouldDisplayNewHomeView = | ||||||||
(isArtsyEmployee || ArtsyNativeModule.isBetaOrDev) && !preferLegacyHomeScreen | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to keep the old logic + the condition of having an artsymail account account There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome 👍🏼 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wondering if this check is now out of sync with this one, which was added previously in #10808 eigen/src/app/utils/useHideSplashScreen.ts Lines 16 to 18 in 1448580
Any cause for concern? I.e. will Artsy users on the app store versions miss out on any pre-fetching? |
||||||||
|
||||||||
const navigateToArtQuiz = async () => { | ||||||||
await navigate("/art-quiz") | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the screens after this change to make sure I didn't break anything
Screen.Recording.2024-09-26.at.17.30.16.mov